Bug 309010 - Some widgets don't respect color theme
Summary: Some widgets don't respect color theme
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 4.6.3
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
: 309602 310044 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-10-25 20:43 UTC by Daniel Vrátil
Modified: 2012-11-19 16:36 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
KMyMoney with dark color theme (141.76 KB, image/png)
2012-10-25 20:43 UTC, Daniel Vrátil
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Vrátil 2012-10-25 20:43:22 UTC
Created attachment 74800 [details]
KMyMoney with dark color theme

It's almost impossible to use KMyMoney with dark color, because some widgets completely ignore color styles. See the attached screenshot for example.
Comment 1 Alvaro Soliverez 2012-10-25 21:03:53 UTC
Have you checked in the settings that KMyMoney is configured to use system colors?
Go to Settings > General > Colors
Comment 2 Daniel Vrátil 2012-10-26 07:34:13 UTC
Didn't occur to me that there would be such option. Sorry for the noise.
Comment 3 Rex Dieter 2012-10-29 19:16:51 UTC
shouldn't "use system colors" really be the default?
Comment 4 Christoph Feck 2012-10-29 23:36:08 UTC
Additionally, even if a custom color theme is used as default, only colors from that custom theme should be used. Mixing it with system colors is a bug. Reopening.
Comment 5 Christoph Feck 2012-10-29 23:38:45 UTC
For a correct implementation, look (or ask) what digiKam and now also Krita developers did.
Comment 6 Alvaro Soliverez 2012-10-30 13:23:15 UTC
That's a wishlist, not the originally reported bug.
Please file a separate one.
Comment 7 Christoph Feck 2012-10-30 21:37:49 UTC
Sorry, I fail to see what different bug should be reported. The issue here is that the user cannot read the text, because widgets are not respecting a single color theme, but mix multiple of them.
Comment 8 Alvaro Soliverez 2012-11-05 18:54:43 UTC
*** Bug 309602 has been marked as a duplicate of this bug. ***
Comment 9 Christoph Feck 2012-11-13 21:29:56 UTC
*** Bug 310044 has been marked as a duplicate of this bug. ***
Comment 10 Cristian Oneț 2012-11-18 13:30:11 UTC
I actually fail to see this bug. Today I've created a collection of screenshots using a dark color theme and I did not found anything wrong besides the ledger group separator column which can be configured. The screenshots can be viewed here http://kmymoney2.sourceforge.net/kmymoney-dark-color-theme.html
Comment 11 Niels van Mourik 2012-11-19 10:54:04 UTC
@Cristian:
The screenshots you've made clearly show that KMyMoney can operate perfectly in a darker color scheme configuration even that ledger group separator is a very minor detail IMHO. What does still make this a bug is the unexpected and non-intuitive requirement of having the end-user check a box in a configuration pane that's hidden away.

It's as simple as this - 99% of all KDE applications blend in very well when the color schemes change and the effort of doing more then 2/3 clicks to make KMyMoney blend in too makes many users give up without reason for a very good software application. In my opinion it might already help to prevent a lot of confusion by simply moving that checkbox to the "general" configuration pane instead of colors, as it's more visible there.

Just my two cents on this, besides this application saved me many times and therefore a BIG BIG thumbs up for all you developers making it for us: very much appreciated.

Niels

What still makes this a bug is the
Comment 12 Cristian Oneț 2012-11-19 10:57:20 UTC
See my comment https://bugs.kde.org/show_bug.cgi?id=310044#c4 I'm reopening this with the requirement to make 'Use system colors' true by default.
Comment 13 Thomas Baumgart 2012-11-19 15:07:36 UTC
Git commit ee1804f00cf94ea1a0b1ee1ddfa29e6c97110249 by Thomas Baumgart.
Committed on 19/11/2012 at 15:58.
Pushed by tbaumgart into branch 'master'.

Make 'Use system color' the default behavior

M  +1    -1    kmymoney/kmymoney.kcfg

http://commits.kde.org/kmymoney/ee1804f00cf94ea1a0b1ee1ddfa29e6c97110249
Comment 14 Thomas Baumgart 2012-11-19 15:08:44 UTC
Git commit 576737baabcab31820e51918dab4b4186cc8fe56 by Thomas Baumgart.
Committed on 19/11/2012 at 15:58.
Pushed by tbaumgart into branch '4.6'.

Make 'Use system color' the default behavior
(cherry picked from commit ee1804f00cf94ea1a0b1ee1ddfa29e6c97110249)

M  +1    -1    kmymoney/kmymoney.kcfg

http://commits.kde.org/kmymoney/576737baabcab31820e51918dab4b4186cc8fe56
Comment 15 Niels van Mourik 2012-11-19 16:36:40 UTC
Wow - very nice and swift action folks!!

Yet again, this proves how much KMyMoney is a wonderful product!

Niels