Bug 308809 - Received contact request menu should have a "Block" action
Summary: Received contact request menu should have a "Block" action
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: kded-module (show other bugs)
Version: git-latest
Platform: unspecified Linux
: NOR wishlist
Target Milestone: 0.6-next
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-22 13:21 UTC by Daniele E. Domenichelli
Modified: 2013-12-29 14:53 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:
ddomenichelli: Decision-Required+


Attachments
Somewhat relevant patch (6.49 KB, patch)
2012-10-23 11:04 UTC, Rohan Garg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele E. Domenichelli 2012-10-22 13:21:04 UTC
When you receive a contact request from a spammer, you might want to block that user even without denying the add request.

See also comments on Bug 297994
Comment 1 Rohan Garg 2012-10-23 09:49:18 UTC
Had a look at this. I tried to implement this using the blocking feature of telepathy where you can block contacts.

Here's what works :
No more pesky notifications

Here's what does not work :
Contact still shows up in the contact list, and the presence is still shown to the user who sent the request.
Comment 2 Rohan Garg 2012-10-23 11:04:37 UTC
Created attachment 74750 [details]
Somewhat relevant patch

Attaching somewhat relevant patch
Comment 3 Daniele E. Domenichelli 2012-10-23 12:55:02 UTC
(In reply to comment #1)
> Here's what does not work :
> Contact still shows up in the contact list,
I believe it is correct, but it should be displayed only when you set the contact list to show the blocked contacts... is this true?

> The presence is still shown to the user who sent the request.
This is weird... what protocol are you using? I tested the "blocking" stuff some time ago and it was working correctly...
Why _still_ shown? The user should not be able to see your presence (presence unknown) until you authorize him, so when you receive the request he should not see you online.
If the person is authorized, when you block a contact your status goes offline (or unknown, I'm not sure).
If he does, perhaps in order to test, you used an account that was your contact and you removed it and then added it again? In that case we might have some issue when removing a contact and the user is not correctly unsubscribed.
Comment 4 Rohan Garg 2012-10-23 15:49:47 UTC
Blergh, Cannot reproduce the issue. Anywho, since that issue is gone, I think I'll go ahead and submit my patch on RB.
Comment 5 Martin Klapetek 2012-10-23 20:20:18 UTC
Fwiw, I just noticed this in g+'s gtalk: 

"N wants to be able to chat with you, and you rejected a previous request. Okay?

[yes] [block]"

How about showing different message for the second time? That would be stored only locally of course, but even if you loose the config file, denying one more time won't kill you.....what do you think?
Comment 6 David Edmundson 2012-10-24 01:31:47 UTC
I think we should go back to basic of working out the use cases.

It's set to be discussed in the meeting we can go through it then.
Comment 7 Daniele E. Domenichelli 2012-10-24 07:04:30 UTC
Just a reminder for the meeting: we need to discuss those related bugs, consider the use cases and decide which of those are valid, and close the others.

Bug 298764 - Received contact request menu should have a "Show profile" action
Bug 298766 - Received contact request menu should have a "Later" action
Bug 298767 - Received contact request menu should have a "Start chat" action
Bug 308809 - Received contact request menu should have a "Block" action
Comment 8 David Edmundson 2013-12-29 14:53:15 UTC
This is now done by default when we deny someone.