Bug 308344 - Display custom tags icons like in the album folder view
Summary: Display custom tags icons like in the album folder view
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Engine (show other bugs)
Version: 3.0.0
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-13 20:49 UTC by Andi Clemens
Modified: 2012-10-17 06:24 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/digikam/86b9232f0eb637c51e604e9f2c19923f8bb29717
Version Fixed In: 3.0.0
Sentry Crash Report:

Attachments
new look (23.66 KB, image/png)
2012-10-13 20:51 UTC, Andi Clemens 		Details
old look (23.34 KB, image/png)
2012-10-13 20:54 UTC, Andi Clemens 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andi Clemens 2012-10-13 20:49:56 UTC 
Currently we are drawing the tag icon around custom tag icons, but it is not consistent with the album view and doesn't look very good in general.
Even when the icon settings are set to 48px, the custom tag is barely visible.

If we decide to use it, I can merge my branch with the master repository.

Reproducible: Always
Comment 1 Andi Clemens 2012-10-13 20:51:59 UTC 
Created attachment 74528 [details]
new look
Comment 2 Andi Clemens 2012-10-13 20:54:42 UTC 
Created attachment 74529 [details]
old look
Comment 3 Marcel Wiesweg 2012-10-15 17:26:38 UTC 
I dont care too much for this area, ok for me. It should clean up a bit of code.
Gilles?
Comment 4 caulier.gilles 2012-10-16 08:07:22 UTC 
Marcel, no probem for me...

Gilles
Comment 5 Andi Clemens 2012-10-16 21:38:39 UTC 
Git commit 86b9232f0eb637c51e604e9f2c19923f8bb29717 by Andi Clemens.
Committed on 13/10/2012 at 20:57.
Pushed by aclemens into branch 'master'.

display custom tag icons like in the album folder view

M  +8    -109  digikam/album/albumthumbnailloader.cpp
M  +1    -10   digikam/album/albumthumbnailloader.h
M  +0    -4    digikam/database/syncjob.cpp
M  +1    -1    digikam/tags/tagspopupmenu.cpp
M  +1    -1    libs/models/albummodel.cpp

http://commits.kde.org/digikam/86b9232f0eb637c51e604e9f2c19923f8bb29717