When a user goes offline from a mobile phone, the phone icon is still displayed next to the offline icon (and this makes no sense). Steps to reproduce: * Show offline contacts in the contact list or apply a filter on display name * Go online from a mobile phone (check that the contact is shown online and the mobile phone icon is displayed * Go offline * The mobile phone icon is still displayed next to the offline icon. * If you close and re-open the contact list, the icon is no longer there.
This is an upstream issue - clientTypes list is not updated when contact goes offline, so Tp::Contact still reports cached values. I opened a report in upstream tracker: https://bugs.freedesktop.org/show_bug.cgi?id=55883 We can workaround this in ContactModelItem by returning empty list for ClientDataRole when contact is offline, or we can just wait for upstream to fix it :)
I think we cannot require a newer version of tp-qt4 for 0.5.2, so we can apply the workaround now, and remove it in master when the upstream bug is fixed
Short update: the upstream bug report has been triaged as an issue in connection manager (telepathy-gabble). We don't have a explicit dependency on gabble, so I suggest reassigning this to 0.6-next to remember to check whether upstream has already fixed the issue and eventually removing the workaround.
I was thinking exactly this, reassigning.
No, we can't have a bug open on something that we've worked around. 1) It'll mess up my release reports 2) Any triager will just close this If you want I'll open a new bug "remove temporary workaround on..." and assign that to 0.6?
Git commit 7157d9e94744ad6f4aabffd28958cd7c0b408df5 by Dan Vrátil. Committed on 12/10/2012 at 13:34. Pushed by dvratil into branch 'kde-telepathy-0.5'. Return empty clientTypes list when contact is offline This is a temporary workaround for upstream bug [0] that should be removed when they fix it. [0] https://bugs.freedesktop.org/show_bug.cgi?id=55883 REVIEW: 106881 M +12 -1 KTp/Models/contact-model-item.cpp M +1 -0 KTp/Models/contact-model-item.h http://commits.kde.org/telepathy-common-internals/7157d9e94744ad6f4aabffd28958cd7c0b408df5