Bug 308097 - Manually editing a filter e-mail address causes KMail filter to fail
Summary: Manually editing a filter e-mail address causes KMail filter to fail
Status: RESOLVED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: filtering (show other bugs)
Version: 4.8.5
Platform: Mandriva RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 22:24 UTC by andrew brewster
Modified: 2012-10-09 07:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description andrew brewster 2012-10-08 22:24:07 UTC
If you edit a filter criteria tha is made semi-automatically, using the context menu option 'Create Filter > Filter on From...' on a e-mail, it will failn
Because you can't edit e-mail addresses in the Available Filters pae, you have to remake the filter once it's broken

Reproducible: Always

Steps to Reproduce:
1. Use an e-mail to make a filter based on the 'From:' field, using the shortcut menu option 'Create filter > Filter on From...' The Filter Rules dialog is opened with the skeleton of the filter filled in for you and the e-mail address shown in the Available Filters pane on the left timmediate after the colon i.e.
'<From>:e-mail@e-mail-address'. 
2. Edit the filter criteria in the right hand pane, add a space at the front, and remove it with the backspace key (or do any other edit of the text or a single character).  The e-mail address in the Available Filters pane now shows a leading space character after the colon i.e.
'<From>: e-mail@e-mail-address'. 
3. 
Actual Results:  
The e-mail as shown in the Available Filters pane seems to be what is used, not as shown in the Filter Criteria pane. The match is exact, including the leading space character, which is never present in the e-mail address used to create the filter, so the filter always fails

Expected Results:  
The Available Filters pane should not add a leading space character to email addresses when the Filter Criteria are edited. It should duplicate any editing done in the Filter Criteria pane. In the example given, it should follow the backspace key, and remove the leading space from the e-mail address

There are any number of bug reports where this may be a contributory factor
Comment 1 Laurent Montel 2012-10-09 07:46:32 UTC
It works fine.
Ok name don't add a space but it's just name.
Will fix it.
But it works fine.

Just look at filter log and reopen with log + filter config (just specific filter) if it doesn't work.
Comment 2 Laurent Montel 2012-10-09 07:54:41 UTC
Git commit 3c58ebf7661a6c752c672e87813cbe52e86859f0 by Montel Laurent.
Committed on 09/10/2012 at 09:53.
Pushed by mlaurent into branch 'KDE/4.9'.

Fix name for filter. Bug 308097

M  +1    -1    mailcommon/filter/kmfilterdialog.cpp

http://commits.kde.org/kdepim/3c58ebf7661a6c752c672e87813cbe52e86859f0
Comment 3 Laurent Montel 2012-10-09 07:54:59 UTC
I fixed name.
But close it.