Bug 308058 - Hidden room tabs in KTP UI should stick out a bit to make them clickable.
Summary: Hidden room tabs in KTP UI should stick out a bit to make them clickable.
Status: RESOLVED UPSTREAM
Alias: None
Product: telepathy
Classification: Unmaintained
Component: text-ui (show other bugs)
Version: 0.5.1
Platform: unspecified Linux
: NOR normal
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 07:39 UTC by Jussi Schultink
Modified: 2013-01-17 13:24 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jussi Schultink 2012-10-08 07:39:47 UTC
like this: http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/ktabbar.png

Reproducible: Always
Comment 1 Rohan Garg 2012-10-08 07:44:55 UTC
We're using a KTabWidget to display the tabs, this could potentially be solved by using a KTabBar instead. Unless KTabWidget is being used for a particular reason.
Comment 2 David Edmundson 2012-11-05 04:10:54 UTC
@Jussi

I don't understand. Our text-ui looks exactly like that. 
What's the difference?

@Rohan

KTabBar/KTabWidget is the same as QTabBar/QTabWidget respectively, i.e, we use KTabBar. TabWidget just also provides the QStackedWidget underneath and connects everything.
Comment 3 David Edmundson 2012-12-10 22:44:40 UTC
Jussi, I am waiting for you to explain what's different.

Marking as "waiting for info"
Comment 4 Jussi Schultink 2012-12-11 07:20:26 UTC
Hi, the picture actually doesn't explain as well as I hoped. 

Here is how to reproduce:

1. open a bunch of tabs, so that several of them are hidden to the left.

2. if you are lucky enough to have one sticking out, click it. 

3. Then try to click the next tab to the left.... 

4. you can't, because it doesn't stick out.

So what I want is like in the picture, but to the left.
Comment 5 David Edmundson 2012-12-11 17:01:12 UTC
I still don't understand.
Do you have a screenshot of tabs done right?
Comment 6 Martin Klapetek 2012-12-11 17:18:43 UTC
If I understand it correctly - basically never align the tab border with window border unless it's the last item (or first) and always "scroll" the tabbar so that the tabs on the edges are always partially visible, suggesting there are more tabs.
Comment 7 David Edmundson 2012-12-11 17:41:51 UTC
That makes sense.

Jussi, can you confirm that's what you meant.

If that is the case, it means deviating from the standard kdelibs tab bar. It's not easy to do, QTabBar does custom painting and event handling on the whole bar at once, basically we would need to rewrite the whole thing.
Comment 8 Jussi Schultink 2012-12-13 07:40:25 UTC
What Martin says is correct, with the additional part that those "stubs" are clickable, not just "suggesting" more.
Comment 9 David Edmundson 2013-01-17 13:24:11 UTC
We use the standard KDE widget for this, it's not in our interest to maintain our own tab bar, it's too much work and not our area of expertise.

If you could follow this up with Qt, that would be great.