Bug 307762 - Improve button setup in modified-on-disk dialogs
Summary: Improve button setup in modified-on-disk dialogs
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: SVN
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks: extramile
  Show dependency tree / graph
 
Reported: 2012-10-03 08:18 UTC by Aurelien Gateau
Modified: 2012-10-03 15:23 UTC (History)
0 users

See Also:
Latest Commit: http://commits.kde.org/kate/5ad035e5b86a826743adb048eb94d30d62a4d5b7
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Aurelien Gateau 2012-10-03 08:18:41 UTC 
The button in the modified-on-disk dialogs could be improved by:

- Always using the same icon for the "Ignore Changes" action.

- Using icons for the "reload" and "save as" actions.

- Turning the whatsthis text into tooltips. The rational for this is that whatsthis are not a very well known feature, I doubt many users will use it. I myself didn't know there were any before looking at the code. It is even worse when not using KWin because other window managers do not have the "?" button.

Related review request for this is on its way.
Comment 1 Aurelien Gateau 2012-10-03 15:23:06 UTC 
Git commit 5ad035e5b86a826743adb048eb94d30d62a4d5b7 by Aurélien Gâteau.
Committed on 03/10/2012 at 17:21.
Pushed by gateau into branch 'master'.

Merge branch 'mod-dialog-buttons'

REVIEW: 106705


http://commits.kde.org/kate/5ad035e5b86a826743adb048eb94d30d62a4d5b7