Bug 307532 - oxygen-qt tooltips aren't rounded in non-composited mode
Summary: oxygen-qt tooltips aren't rounded in non-composited mode
Status: RESOLVED WORKSFORME
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Christoph Feck
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-28 14:38 UTC by Ruslan Kabatsayev
Modified: 2020-11-11 04:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ruslan Kabatsayev 2012-09-28 14:38:24 UTC
We do use XShape for oxygen-gtk tooltips in the same way as for menus and combos, but it's not done for oxygen-qt tooltips.

Reproducible: Always
Comment 1 Hugo Pereira Da Costa 2012-11-04 12:09:10 UTC
As a matter of fact, this was done on purpose ... 'we' (= nuno, but I also) prefer having square pixmaps than pixelized masks for these tiny widgets (notably because the 'contrast' pixel on the border is somewhat poorly rendered when a mask is used). In fact, maybe we should change the other way around and disable the mask (in oxygen-gtk), when compositing is not available. (it was introduced earlier because this was the only alternative we had before learning how to set argb colormap on tooltips, iirc). What do you think ? 

(besides: tooltips for firefox and co are already squared) ...
Comment 2 Ruslan Kabatsayev 2012-11-04 12:34:06 UTC
I wouldn't say they are tiny:
http://6g6.eu/sih0-screenshot-11042012-042950-pm.png
I think this looks no good. This tooltip blends with window background and is hardly distinguishable from the window. And of course, setting tooltip bg to black as done in Oxygen color scheme is just a workaround, not a fix.
Comment 3 Hugo Pereira Da Costa 2012-11-04 12:44:52 UTC
mmm
As a matter of fact, which tooltips are you refering too.
Here, normal tooltips are "masked" (and pixel-rounded). 
(e.g.: mouse-over a toolbutton).
Custom tooltips (in e.g. dolphin) are not, but that's dolphin's fault. 

See: http://wstaw.org/m/2012/11/04/plasma-desktopyH4491.png

Or am I missing something ? 

Hugo
Comment 4 Hugo Pereira Da Costa 2012-11-04 12:46:07 UTC
at comment #2: yeah. Custom tooltip. That's systemsetting's fault.
Comment 5 Hugo Pereira Da Costa 2012-11-04 12:46:39 UTC
should use style()->styleHint( SH_TOOLTIP_MASK, ...)
(or somthing similar).
Comment 6 Hugo Pereira Da Costa 2012-11-04 12:48:02 UTC
... reassigning.
Comment 7 Hugo Pereira Da Costa 2012-11-04 12:54:14 UTC
PS: even when rounded, the screenshot above would still not look good.
But this is due to the palette.
Tooltips are supposed to have a different background than windows, and this is why we dont draw a hard border on them. Design choice.
The fact that with compositing, the tooltip is still well differenciated from the window, due to the shadow, is just accidental. Wont change the border of the tooltips to accomodate this kind of color palettes. Sorry. 
(in fact there was a different bug report about this some time ago, that we rejected for the same reason).

That does not invalidate the systemsetting (and dolphin) "round mask" bug, though.
Comment 8 Nate Graham 2020-10-12 21:54:11 UTC
Is this still relevant?
Comment 9 Nate Graham 2020-10-12 23:33:37 UTC
text
Comment 10 Bug Janitor Service 2020-10-27 04:33:27 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 11 Bug Janitor Service 2020-11-11 04:33:56 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!