Reminds me of my old patches for that view, I somehow lost them, see http://kdepepo.wordpress.com/2009/07/29/spot-the-difference/ Exercise 2 Snapshot...

I'm impressed, that looks much better and is better to distinguish than the current implementation. It really would be great if you could rebuild that.

Actually, while filtering review requests in kde-artists, I found this one:

http://lists.kde.org/?t=124895718300005&r=1&w=1

Adding that for anyone wanting to improve the patch and fix the issues that were raised there.

Maybe using an ItemView rather than a ListView would be better, so we can have much bigger previews similar to what eg. Plasma has in its wallpaper selection dialog. I will try to keep it in mind for 4.11 :-)

Git commit b52c0cebfb98a76089e0658d7e3824b4c0d34d63 by Kai Uwe Broulik.
Committed on 24/01/2019 at 13:26.
Pushed by broulik into branch 'master'.

[Colors KCM] Port to new design

Overall the user experience has been streamlined and simplified a lot:

* The "Default" theme option has been dropped in favor of having the "Defaults" button revert the selected theme to Breeze.
  While technically the old code made it read the hardcoded default colors in KColorScheme (which cause the window decoration
  to turn blue as it cannot write into KWin config like the theme files can), this change makes most sense from a UX POV.
* The "Current" theme option has also been removed. Technically, when applying a theme the colors are copied into kdeglobals,
  so you could have a custom theme that is not an actual .colors file on disk. However, this is imho quite a niche usecase.
  Ideally, we showed a "Custom" theme as soon as the actual theme diverges from any theme file installed but that would require
  tediously comparing dozens of settings values which I don't think is feasible. At least when the color scheme name set in
  kdeglobals does not exist, a warning is now displayed.
* The "Apply to non-Qt applications checkbox" which isn't something one would want to uncheck has been removed.
  It is still read from kcmdisplayrc for those who really want to disable it but there is no user-visible checkbox anymore.

KColorSchemeEditor is now completely disentangled from the KCM and is merely launched as separate process:

* When editing a system scheme, upon clicking "Save" the user is prompted to type a new scheme name. This ensures that any custom
  scheme is always present on disk reducing the need for a "Current" entry. When the dialog is then closed, the newly saved theme
  is selected.
* When editing a user scheme, the "Save" button turns into "Apply", which when clicked updates the scheme with any changes made in
  the dialog (different behavior from when kcolorschemeeditor is launched standalone, where "Save" is always essentially "Save As")

The rewrite also comes with all the goodies we got in the other new KCMs, such as the ability to drop a .colors file into the view
to install it (even from remote locations), undo deletion until you apply your changes, double click for quick apply, and so on.
FIXED-IN: 5.16.0

Differential Revision: https://phabricator.kde.org/D12278

M  +21   -72   kcms/colors/CMakeLists.txt
M  +1    -1    kcms/colors/Messages.sh
D  +0    -3    kcms/colors/TODO
A  +565  -0    kcms/colors/colors.cpp     [License: GPL (v2/3)]
A  +118  -0    kcms/colors/colors.h     [License: GPL (v2/3)]
D  +0    -569  kcms/colors/colorscm.cpp
D  +0    -141  kcms/colors/colorscm.h
A  +33   -0    kcms/colors/editor/CMakeLists.txt
R  +0    -0    kcms/colors/editor/colorsettings.ui [from: kcms/colors/colorsettings.ui - 100% similarity]
R  +25   -1    kcms/colors/editor/kcolorschemeeditor.cpp [from: kcms/colors/kcolorschemeeditor.cpp - 071% similarity]
R  +0    -0    kcms/colors/editor/org.kde.kcolorschemeeditor.desktop [from: kcms/colors/org.kde.kcolorschemeeditor.desktop - 100% similarity]
R  +0    -0    kcms/colors/editor/preview.ui [from: kcms/colors/preview.ui - 100% similarity]
R  +0    -0    kcms/colors/editor/previewwidget.cpp [from: kcms/colors/previewwidget.cpp - 100% similarity]
R  +0    -0    kcms/colors/editor/previewwidget.h [from: kcms/colors/previewwidget.h - 100% similarity]
R  +0    -0    kcms/colors/editor/scmeditorcolors.cpp [from: kcms/colors/scmeditorcolors.cpp - 100% similarity]
R  +0    -0    kcms/colors/editor/scmeditorcolors.h [from: kcms/colors/scmeditorcolors.h - 100% similarity]
R  +0    -0    kcms/colors/editor/scmeditorcolors.ui [from: kcms/colors/scmeditorcolors.ui - 100% similarity]
R  +39   -39   kcms/colors/editor/scmeditordialog.cpp [from: kcms/colors/scmeditordialog.cpp - 085% similarity]
R  +9    -8    kcms/colors/editor/scmeditordialog.h [from: kcms/colors/scmeditordialog.h - 084% similarity]
R  +0    -0    kcms/colors/editor/scmeditordialog.ui [from: kcms/colors/scmeditordialog.ui - 100% similarity]
R  +0    -0    kcms/colors/editor/scmeditoreffects.cpp [from: kcms/colors/scmeditoreffects.cpp - 100% similarity]
R  +0    -0    kcms/colors/editor/scmeditoreffects.h [from: kcms/colors/scmeditoreffects.h - 100% similarity]
R  +0    -0    kcms/colors/editor/scmeditoreffects.ui [from: kcms/colors/scmeditoreffects.ui - 100% similarity]
R  +0    -0    kcms/colors/editor/scmeditoroptions.cpp [from: kcms/colors/scmeditoroptions.cpp - 100% similarity]
R  +0    -0    kcms/colors/editor/scmeditoroptions.h [from: kcms/colors/scmeditoroptions.h - 100% similarity]
R  +0    -0    kcms/colors/editor/scmeditoroptions.ui [from: kcms/colors/scmeditoroptions.ui - 100% similarity]
R  +0    -0    kcms/colors/editor/setpreview.ui [from: kcms/colors/setpreview.ui - 100% similarity]
R  +0    -0    kcms/colors/editor/setpreviewwidget.cpp [from: kcms/colors/setpreviewwidget.cpp - 100% similarity]
R  +0    -0    kcms/colors/editor/setpreviewwidget.h [from: kcms/colors/setpreviewwidget.h - 100% similarity]
R  +2    -41   kcms/colors/kcm_colors.desktop [from: kcms/colors/colors.desktop - 081% similarity]
A  +280  -0    kcms/colors/package/contents/ui/main.qml     [License: GPL (v2/3)]
A  +16   -0    kcms/colors/package/metadata.desktop

https://commits.kde.org/plasma-desktop/b52c0cebfb98a76089e0658d7e3824b4c0d34d63