Bug 307085 - bookmar k shortcut is CTRL+D - but I used it up to now to close terminal sessions!
Summary: bookmar k shortcut is CTRL+D - but I used it up to now to close terminal sess...
Status: RESOLVED NOT A BUG
Alias: None
Product: konsole
Classification: Applications
Component: bookmark (show other bugs)
Version: 2.8.5
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 06:40 UTC by stephan
Modified: 2012-10-15 13:02 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
after pressing CTRL+D this popup appears. (67.61 KB, image/png)
2012-09-20 14:04 UTC, stephan
Details
adding a bookmark (Lesezeichen hinzufügen) is CTRL+D as a standard. (108.77 KB, image/png)
2012-09-20 14:06 UTC, stephan
Details
here you can see that indeed CTRL+D is the default (51.82 KB, image/png)
2012-09-20 14:19 UTC, stephan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description stephan 2012-09-20 06:40:47 UTC
What a funny idea to use CTRL+D as a shortcut for bookmarks - a feature I never used before. What I used extensively is CTRL+D to close sessions. Please, I want to be able to close sessions with CTRL+D as before.

Reproducible: Always

Actual Results:  
Press CTRL+D -> Session closes

Expected Results:  
Press CTRL+D -> Konsole Popup opens
Comment 1 Jekyll Wu 2012-09-20 11:40:11 UTC
Sorry, but this report is not funny or pleasant to read at all.

First, I can guarantee to you that KDE4 konsole has never assign "Ctrl+D" as the default shortcut for adding bookmarks. The default shortcut for that action has been *effectively* "Ctrl+Shift+B" almost ever since KDE4. If you know how to use git, then just fetch code from git://anongit.kde.org/konsole.git, and use "git blame src/MainWindow.cpp" to check whether I'm lying. The keyword for blaming is "add_bookmark" . That statement for "Ctrl+D" should also hold for other actions, but I'm 100% confident because I haven't spend the time to do the blaming for all actions.

Second, this bug report does not provide any version information of KDE and konsole. That makes this bug report only half useful, although I don't think this report in current form will be useful even after those information are added. 

Third, "Press CTRL+D -> Konsole Popup opens". Can it be more clear? Where is the screenshot for that "Popup"? 
    
Last, please use common sense before opening new reports, seriously. 

    * Are konsole developers stupid enough to make that suspected decision?
    * Do konsole developers never use konsole themselves, or never know and use "Ctrl+D" to close a shell?
    * Do you think you are the first and only person to discover this stupid decision? Are all other konsole users not smart enough to discover it, if it really exists? Why has nobody reported it? But I guess you simply does not search existing reports before opening new reports.

Now come back to why "Ctrl+D" is assigned to adding bookmark(or whatever action) in you system:

1. Your distribution makes that stupid decision and ships a patched konsole.  But you didn't provide the distribution information either, so that is just a guess which can't be further investigated.

2. You accidentally assigned "Ctrl+D" as shortcut, but you forgot that and thought that was the default and here comes this report.

So please attach ~/.kde4/share/apps/konsole/konsoleui.rc and ~/.kde4/share/apps/konsole/konsole/sessionui.rc  . 

<rant>
Some users think writing useful bug reports is a easy task, and they can do it within 5 minutes and a few (not clear enough) sentences. That is not the truth. 
</rant>
Comment 2 Jekyll Wu 2012-09-20 11:43:03 UTC
"1. Your distribution makes that stupid decision and ships a patched konsole.  But you didn't provide the distribution information either, so that is just a guess which can't be further investigated."

Ignore this part. Apparently I have overlooked some information.
Comment 3 stephan 2012-09-20 14:04:40 UTC
Created attachment 74051 [details]
after pressing CTRL+D this popup appears.
Comment 4 stephan 2012-09-20 14:06:55 UTC
Created attachment 74052 [details]
adding a bookmark (Lesezeichen hinzufügen) is CTRL+D as a standard.
Comment 5 stephan 2012-09-20 14:17:49 UTC
Sorry for my unpleasant report.
But as you can see in the attachements, in my konsole the default bookmark for adding a bookmark is indeed defined as CTRL+D (I changed this now for my convenience).
Sorry about the missing versions (thought I had filled everything): Konsole is 2.8.5, KDE is 4.8.5

Sorry to open this report, but I have assumed nothing - I just was a bit confused as to why this didn't work as expected anymore. And I checked for other reports beforehand. As I didn't find anything I started my own report. 
But I understand - assuming that anybody should have seen this before should be enough reason to stay out of this business ;-)

enough ranting back - I'll supply the needed information ...
Comment 6 stephan 2012-09-20 14:19:31 UTC
Created attachment 74053 [details]
here you can see that indeed CTRL+D is the default
Comment 7 stephan 2012-09-20 14:23:33 UTC
"So please attach ~/.kde4/share/apps/konsole/konsoleui.rc and ~/.kde4/share/apps/konsole/konsole/sessionui.rc . "
Sorry, ~/.kde4/share/apps holds no directory "konsole" at my place
Comment 8 Jekyll Wu 2012-09-20 15:59:11 UTC
OK, thanks for all added information. Now let me add basic analysis of the problem.

1. You are using KDE 4.8.5.  That is an important clue which makes it much easier to find one related commit: http://commits.kde.org/konsole/a02f0dccb949c5d9747f66f477a3586f6df490f1 . 

That commit makes the assmuption that the "Add Bookmark" action has "Ctrl+B" as its default shortcut (that is inherited from standard shortcuts and is problematic for an shell running in terminal emulator), and tries to fix that problem when appropriate instead of always(because the old way means users can't effectively change the shortcut of that action ).

So version information is really important and helpful. Please always provide it when reporting bugs.

2. You are using a localized KDE, as reflected in those screenshots.  Screenshot in comment #4 shows that "Ctrl+D" is the default shortcut for the "Add Bookmark" action. Since that default shortcut is (as mentioned above) inherited from standard shortcuts, I suspect:

    * The default shortcut for "Add Bookmark" in konqueror is also "Ctrl+D".
    * Go to "System Settings -> Shortcuts and Gestures -> Standard Keyboard  Shortcuts", search for "Add Bookmark", and its _active_ shortcut is also "Ctrl+D" (but its default shortcut is Ctrl+B ?).  

If true, then the next question is why is it "Ctrl+D" instead of "Ctrl+B" as expected ?

    * A result of localization ? I really don't think so, but I'm no expert of localization.

    * Have you changed it manually before?

A side note: it is generally better to provide screenshots in English instead of localized language. I even don't know which language/localization is in use in those screenshots, not to mention understanding and trying to reproduce it.

(In reply to comment #7)
> "So please attach ~/.kde4/share/apps/konsole/konsoleui.rc and
> ~/.kde4/share/apps/konsole/konsole/sessionui.rc . "
> Sorry, ~/.kde4/share/apps holds no directory "konsole" at my place

I guess that is because Ubuntu uses ~/.kde instead of ~/.kde4 . But never mind, I asked for those files to see whether "Ctrl+D" comes from your personal customization of konsole itself. That is apparently not the case according to those screenshots.
Comment 9 Christoph Feck 2012-09-20 20:12:51 UTC
Burkhard, could this be a german localization issue?
Comment 10 Christoph Feck 2012-09-20 20:17:21 UTC
Jekyll, does Konsole use some heuritics to remap Ctrl+* to Ctrl+Shift+* ? Here, it says that Ctrl+B is "Standard", but Konsole automatically selected Ctrl+Shift+B as current shortcut (and I never changed them).
Comment 11 Jekyll Wu 2012-09-20 20:49:12 UTC
(In reply to comment #10)
> Jekyll, does Konsole use some heuritics to remap Ctrl+* to Ctrl+Shift+* ?
> Here, it says that Ctrl+B is "Standard", but Konsole automatically selected
> Ctrl+Shift+B as current shortcut (and I never changed them).

No, there is no such general rule. That "Add Bookmark" case is an exception, or the result of some hack. See http://lxr.kde.org/source/kde/kde-baseapps/konsole/src/MainWindow.cpp#175 .
Comment 12 Christoph Feck 2012-09-20 21:04:53 UTC
Stephan, can you check in System Settings > Shortcuts > Standard Keyboard Shortcuts what's currently assigned as the "Add Bookmark" shortcut? It's possible you changed it there, and Konsole's hack^Wexception code doesn't handle that.
Comment 13 Burkhard Lück 2012-09-21 10:44:15 UTC
(In reply to comment #9)
> Burkhard, could this be a german localization issue?

$ konsole --version
Qt: 4.8.0
KDE: 4.9.00
Konsole: 2.8.5

Shortcut for "Lesezeichen hinzufügen" (Add Bookmark) is Ctrl+B in the above mentioned version of konsole compiled from sources running in locale "de" with default settings.
Comment 14 Jekyll Wu 2012-09-24 11:03:20 UTC
Wait for information requested in comment #12
Comment 15 Mike C. Fletcher 2012-09-29 02:25:12 UTC
I saw the same symptom appear just now on a Candian English Kubuntu 12.04 box.  Previously (i.e. many times a day for the last few years) CTRL-D was just passed to the console.  Today, after I happened to exit every Konsole instance and restart it, ctrl-d brought up an add Bookmark dialog.  Same version of Konsole (2.8.5).  The system settings dialog had a non-default ctrl-d selection, switching back to default (ctrl-b) solved the issue.

ctrl-d is used extensively in e.g. python interpreters to exit, btw.  If this is some Kubuntu change it should likely be reverted.
Comment 16 Jekyll Wu 2012-09-29 12:26:51 UTC
(In reply to comment #15)
> I saw the same symptom appear just now on a Candian English Kubuntu 12.04
> box.  Previously (i.e. many times a day for the last few years) CTRL-D was
> just passed to the console.  Today, after I happened to exit every Konsole
> instance and restart it, ctrl-d brought up an add Bookmark dialog.  Same
> version of Konsole (2.8.5).  The system settings dialog had a non-default
> ctrl-d selection, switching back to default (ctrl-b) solved the issue.
> 
> ctrl-d is used extensively in e.g. python interpreters to exit, btw.  If
> this is some Kubuntu change it should likely be reverted.

Although the information is not from the original reporter  as requested .....

If the root cause is (as expected) that the value for "Add bookmark" in standard keyboard shortcuts has been "magically" modified  from "Ctrl+B" to "Ctrl+D", then I think the problem is out of the scope of this konsole product.

I can add extra check for "Ctrl+D" into the existing hack, but that is not a good idea and does not scale. What about "Ctrl+W", "Ctrl+R", "Ctrl+K" and other common keys?  That hack exists only because the default "Ctrl+B" is problematic for a terminal emulator, nothing more. If users have intentionally or accidentally assigned "Ctrl+D", then konsole needn't and shouldn't try to avoid that mistake.

As for why "Ctrl+D" is magically introduced in your system,  I really have no idea.
Comment 17 stephan 2012-10-03 13:44:20 UTC
(In reply to comment #8)
> 2. You are using a localized KDE, as reflected in those screenshots. 
> Screenshot in comment #4 shows that "Ctrl+D" is the default shortcut for the
> "Add Bookmark" action. Since that default shortcut is (as mentioned above)
> inherited from standard shortcuts, I suspect:
> 
>     * The default shortcut for "Add Bookmark" in konqueror is also "Ctrl+D".
>     * Go to "System Settings -> Shortcuts and Gestures -> Standard Keyboard 
> Shortcuts", search for "Add Bookmark", and its _active_ shortcut is also
> "Ctrl+D" (but its default shortcut is Ctrl+B ?).  
> 
> If true, then the next question is why is it "Ctrl+D" instead of "Ctrl+B" as
> expected ?
> 
>     * A result of localization ? I really don't think so, but I'm no expert
> of localization.
> 
>     * Have you changed it manually before?
> 
Hello,

Sorry for being late - but I had no access to my PC for the last couple of days.
Yes, you are right - shortcut in system settings for adding a bookmark is CTRL+D - but the default one is CTRL+B. But actually I have no idea as to why this is the case. I have not changed any of these standard shortcuts as to my knowledge.

> A side note: it is generally better to provide screenshots in English
> instead of localized language. I even don't know which language/localization
> is in use in those screenshots, not to mention understanding and trying to
> reproduce it.
> 
this is german. sorry, will set kde to english next time.

regards,
stephan
Comment 18 stephan 2012-10-03 13:51:25 UTC
I have set the add-bookmark shortcut in system-settings - standard-shortcuts from CTRL+D to CTRL+B and it did solve the problem in konsole for me, too. But as said before, I have no idea, why it was changed to CTRL+D in the first place ...
Comment 19 Jekyll Wu 2012-10-15 12:21:48 UTC
Well, then I will close this report since it can't move forward in any direction based upon existing information. All we know is "Ctrl+B" for adding bookmark is magically changed to "Ctrl+D" in standard keyboard shortcuts.

If this problem happens again, open a new report under systemsettings/kcm_standard_actions and mention this report in your descipriotn. This report is already kind of  messed up, which makes it not suitable for reassigning.
Comment 20 stephan 2012-10-15 13:02:43 UTC
ok! kind regards