Bug 306879 - Filter sections folding behavior is weird
Summary: Filter sections folding behavior is weird
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Filters (show other bugs)
Version: 3.0.0
Platform: Ubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL: http://imageshack.us/a/img833/9314/di...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-16 10:17 UTC by Mathieu MD
Modified: 2012-09-17 15:44 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 3.0.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu MD 2012-09-16 10:17:40 UTC
In the Filters tab (bottom right), the vertical space used seems to depend on which section is fold or not.

See the screenshot linked: http://imageshack.us/a/img833/9314/digikam280filtersection.png

Reproducible: Always

Steps to Reproduce:
1. Open the "Filters" tab
2. (check all sections are unfolded)
3. Fold the "geolocalisation" section
4. See how the "tag filters" do not use all the vertical space anymore
5. Fold all sections
6. Unfold the "geolocalisation" section
7. See how the vertical space used by all sections is different than at step 5.
Actual Results:  
Vertical space used is not always the same

Expected Results:  
Vertical space use should be coherent
Comment 1 Smit Mehta 2012-09-16 11:54:49 UTC
Hi Mathieu

I confirm the bug. We will look into it.

Smit
Comment 2 Smit Mehta 2012-09-16 17:17:15 UTC
Hi Gilles

I think its just a simple typo. Look at this :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/filters/filtersidebarwidget.cpp#L271

Actually i think, its intended for "tag filters" instead of "geo tags" to expand. It looks more consistent. So whenever you open "tags filter", it will take up the entire space available, because it requires more space due to scrollbar area inside it. Otherwise, it should be extended.

If I make that condition to be (id==3) it will behave better. What do you think? If its fine, i will commit it in current git/master on 18 sept. So that it wont hurt beta packaging.

Smit
Comment 3 caulier.gilles 2012-09-16 17:27:07 UTC
Smit,
yes, it's a typo...
In fact why int values are used here to define view section. We must use an enum of values with human readable names...

Gilles
Comment 4 Smit Mehta 2012-09-17 15:42:37 UTC
Git commit ae2e4874ab324d49a96f4f1852213ac9f5577484 by Smit Mehta.
Committed on 17/09/2012 at 17:42.
Pushed by smitmehta into branch 'master'.

fixed typo in filtersiderbarwidget.cpp
added enum for more readibility

M  +2    -1    .gitignore
M  +2    -1    NEWS
M  +1    -1    digikam/filters/filtersidebarwidget.cpp
M  +9    -0    digikam/filters/filtersidebarwidget.h

http://commits.kde.org/digikam/ae2e4874ab324d49a96f4f1852213ac9f5577484