Bug 306313 - Add dbus way to access the non first Okular::part
Summary: Add dbus way to access the non first Okular::part
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2012-09-05 20:50 UTC by Albert Astals Cid
Modified: 2012-09-25 19:30 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/okular/b1152329661d841219250a2165347b0d224f57ab
Version Fixed In: 4.10.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Astals Cid 2012-09-05 20:50:14 UTC 
With the current code the first Okular::Part gets registered as org.kde.okular and the rest just fail to register as the name is already taken.

We should add them with the org.kde.okular_N name where N is an incremental name from 1 to X
Comment 1 jaydeep17 2012-09-06 18:14:44 UTC 
I'll have a try :)
Comment 2 Albert Astals Cid 2012-09-19 20:41:31 UTC 
The same has to be done for the shell
Comment 3 Albert Astals Cid 2012-09-25 19:28:26 UTC 
Actually we don't really need the same for the shell
Comment 4 Albert Astals Cid 2012-09-25 19:30:37 UTC 
Git commit b1152329661d841219250a2165347b0d224f57ab by Albert Astals Cid, on behalf of Jaydeep Solanki.
Committed on 25/09/2012 at 21:26.
Pushed by aacid into branch 'master'.

D-Bus access to non-first Okular::Part

REVIEW: 106531
FIXED-IN: 4.10.0

M  +9    -2    part.cpp
M  +2    -0    part.h

http://commits.kde.org/okular/b1152329661d841219250a2165347b0d224f57ab