Bug 306243 - Sensor browser tree is not localized
Summary: Sensor browser tree is not localized
Status: RESOLVED WORKSFORME
Alias: None
Product: ksysguard
Classification: Unmaintained
Component: ksysguard (show other bugs)
Version: 4.9.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-04 09:57 UTC by Szczepan Hołyszewski
Modified: 2019-04-11 04:33 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
untranslated strings in red and translated, but cut off strings in blue (78.08 KB, image/png)
2013-03-04 13:00 UTC, Burkhard Lück
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Szczepan Hołyszewski 2012-09-04 09:57:37 UTC
The sensor browser tree shown on a newly added card in ksysguard is not localized - all labels appear in English, even though I am using Polish localization.


Reproducible: Always

Steps to Reproduce:
1. Install and activate Polish localization of KDE
2. Open ksysguard
3. Add new card
Actual Results:  
Labels in the sensor tree are all in English.

Expected Results:  
The labels should be in Polish.
Comment 1 Burkhard Lück 2013-02-04 18:25:04 UTC
Git commit e0163a0db0cc7fa9b0c35af98afcf44b9769327a by Burkhard Lück.
Committed on 04/02/2013 at 19:24.
Pushed by lueck into branch 'master'.

extract messages for ksgrd
Some strings remain still untranslated:
localhost
(float) + (integer) + (listview)
xxACPIxx
-> Cooling_Device ->[012]-> Current State (integer) - can't be added
-> Thermal_Zone -> Temperature  (integer)
logfiles
-> messages (logfile)
-> kern (logfile)
-> daemon (logfile)
-> syslog (logfile)
-> auth (logfile)
xxNetworkxx wlan
-> quality (float) + signal (float) + noise (float) etc

These translation strings are manually defined in a dictionary in
SensorManager.cpp.
Maybe some strings definitions are missing or have wrong keyword, that's why
they are still untranslatable.

A  +2    -0    libs/ksysguard/ksgrd/Messages.sh

http://commits.kde.org/kde-workspace/e0163a0db0cc7fa9b0c35af98afcf44b9769327a
Comment 2 Burkhard Lück 2013-02-04 18:28:13 UTC
Git commit bd3e483cfabb8b735651b4cdaa4553a8060272c2 by Burkhard Lück.
Committed on 04/02/2013 at 19:24.
Pushed by lueck into branch 'KDE/4.10'.

extract messages for ksgrd
(cherry picked from commit e0163a0db0cc7fa9b0c35af98afcf44b9769327a)

A  +2    -0    libs/ksysguard/ksgrd/Messages.sh

http://commits.kde.org/kde-workspace/bd3e483cfabb8b735651b4cdaa4553a8060272c2
Comment 3 Albert Astals Cid 2013-03-03 23:39:47 UTC
Git commit 5cb9703aefd5ef64a0b3de81eed1f8f0051dd2a4 by Albert Astals Cid.
Committed on 04/03/2013 at 00:38.
Pushed by aacid into branch 'KDE/4.10'.

More i18n for ksysguard

Burkhard there are things you say are untranslatable i can't find, can you please point them to me with a screenshot?

M  +1    -1    ksysguard/gui/SensorBrowser.cpp
M  +4    -0    libs/ksysguard/ksgrd/SensorManager.cpp

http://commits.kde.org/kde-workspace/5cb9703aefd5ef64a0b3de81eed1f8f0051dd2a4
Comment 4 Burkhard Lück 2013-03-04 13:00:34 UTC
Created attachment 77741 [details]
untranslated strings in red and translated, but cut off strings in blue
Comment 5 Albert Astals Cid 2013-06-16 20:42:40 UTC
If anyone feels like giving it a try i think it basically means adding stuff to the mDict map in SensorManager.cpp like
  mDict.insert( QLatin1String( "quality" ), i18n( "Quality" ) );
should give us the hability to translate the "quality" field of the wifi part in there.

But i don't have much time to try it really works, Burkhard do you think you can give it a shot?
Comment 6 Albert Astals Cid 2015-10-12 21:10:17 UTC
Git commit db6f6b3c9a4a415b391dbcfd3d25ef5bd65c7f18 by Albert Astals Cid.
Committed on 12/10/2015 at 21:09.
Pushed by aacid into branch 'master'.

Add translations for wifi stuff

M  +16   -0    ksgrd/SensorManager.cpp

http://commits.kde.org/libksysguard/db6f6b3c9a4a415b391dbcfd3d25ef5bd65c7f18
Comment 7 Albert Astals Cid 2015-10-12 21:31:05 UTC
Git commit 5386346a502a05f0ce3bbdcdf2dc3ebfb303cb85 by Albert Astals Cid.
Committed on 12/10/2015 at 21:30.
Pushed by aacid into branch 'master'.

Add i18n for log files

M  +3    -0    ksgrd/SensorManager.cpp

http://commits.kde.org/libksysguard/5386346a502a05f0ce3bbdcdf2dc3ebfb303cb85
Comment 8 Albert Astals Cid 2015-10-12 22:05:10 UTC
Git commit 3b4ef4c032e247ffcd2e38e152cf2b079b634f38 by Albert Astals Cid.
Committed on 12/10/2015 at 22:04.
Pushed by aacid into branch 'master'.

Fix titles being cut at the first space

Since titles can have spaces we don't have to take parts[3] but the rest of the parts from 3 to the end joined by ' '

M  +1    -1    gui/WorkSheet.cpp

http://commits.kde.org/ksysguard/3b4ef4c032e247ffcd2e38e152cf2b079b634f38
Comment 9 Richard Llom 2019-03-12 20:50:07 UTC
Can you reproduce this issue with the current version of ksysguard?
Comment 10 Bug Janitor Service 2019-03-27 04:33:13 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 11 Bug Janitor Service 2019-04-11 04:33:15 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!