Bug 306192 - Regression in KDE file open dialogs filter handlinng
Summary: Regression in KDE file open dialogs filter handlinng
Status: RESOLVED WORKSFORME
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: kdecore (show other bugs)
Version: 4.8.4
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Parker Coates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-03 11:09 UTC by Daniel Teske
Modified: 2020-12-08 04:34 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Teske 2012-09-03 11:09:04 UTC
The  commit in kdelibs: 6344c4f0505f7a0994bd7f36e5c607959d2dfbcf breaks qt creator's file dialog for qmake. See the bug report https://bugreports.qt-project.org/browse/QTCREATORBUG-7771 .

The root cause of that is that the filter in the line ops->setNameFilter('*' + filter.replace(' ', '*') + '*'); is "qmake-qt4 qmake4 qmake".

Obviously we want to match exactly those files, not "qmake-qt4*qmake4*qmake"

Reproducible: Always
Comment 1 Michael Pyne 2012-09-03 21:26:20 UTC
Git commit 692d5bb79649cbfb5290089e585708d5dd1b30e2 by Michael Pyne.
Committed on 03/09/2012 at 21:53.
Pushed by mpyne into branch 'KDE/4.9'.

kshareddatacache: Add simple fallback spinlock.

This is a very simple spinlock busy-waiting class to allow for a
process-shared, shared-memory lock when the operating system does not
provide a suitable anonymous lock.

Based on code from Till Adam and Thiago Macieira.

One of the intended targets is OpenBSD which doesn't seem to support
sched_yield, so they get nanosleep instead. This check should be shifted
to a CMake check once that patch is integrated.

Since this spinlock "should work everywhere" I remove support for
finding thread-only locks (to be clear, support for such has always been
a bug itself). If no standard POSIX primitive is available for
process-shared use we fall back to this spinlock.

Code was tested by artificially forcing the spinlock to be used,
removing all caches, and then running the test case and several heavy
users of the class (e.g. KPat and lskat).

This should hopefully be sufficient to eliminate the crashing
experienced in OpenBSD although I intend to continue merging the CMake
cleanups (but in KDE/4.10).
FIXED-IN:4.9.2

M  +77   -15   kdecore/util/kshareddatacache_p.h

http://commits.kde.org/kdelibs/692d5bb79649cbfb5290089e585708d5dd1b30e2
Comment 2 Michael Pyne 2012-09-03 22:28:49 UTC
Sorry, closed out the wrong bug. :-/
Comment 3 Justin Zobel 2020-11-08 01:04:21 UTC
Daniel is this still occurring in recent KDE / qtcreator?
Comment 4 Bug Janitor Service 2020-11-23 04:33:49 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2020-12-08 04:34:12 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!