Large tooltips especially with hyperlinks (eg. in eclipse-sdk) are nearly unreadable. Colors are badly chosen. Reproducible: Always Steps to Reproduce: 1.show a large tooltip in gtk-based application eg. move cursor to underlined error or warning in eclipse-sdk. Actual Results: Text in tooltips is contrastless in comparison with background. As shown in first screenshont. Expected Results: Tooltips should be more readable. Example is on second screenshot. I've created quick and dirty workaround by editing /usr/share/themes/oxygen-gtk/gtk-2.0/kdeglobals. This is a diff: 51c51 < BackgroundNormal=24,21,19 --- > BackgroundNormal=255,255,167 59,61c59,61 < ForegroundNormal=231,253,255 < ForegroundPositive=0,110,40 < ForegroundVisited=100,74,155 --- > ForegroundNormal=0,0,0 > ForegroundPositive=0,10,40 > ForegroundVisited=0,74,155
Created attachment 73499 [details] Current, bad readable tooltip.
Created attachment 73500 [details] Example of more readable tooltip.
Basically its a bug with oxygen's color scheme, rather than oxygen-gtk. One could argue that tooltips are not supposed to be interacted with and there should be no "links" in there Your patch looks good, but breaks consistency with KDE apps when using "default" color scheme. I'd rather suggest you make your own change to $HOME/.kde/share/config/kdeglobals, which takes precedence over oxygen-gtk's default, and would change Qt applications also, consistently, rather than changing oxygen-gtk's default, that would make it inconsistent with KDE's default colorscheme. Make sense ? One could also re-submit this bug report to Oxygen's color scheme.
@Hugo In fact, it seems there's still something we should do in oxygen-gtk: we don't set gtkrc link-color based on kdeglobals (at least I couldn't find any pointers to this).
@Ruslan You're right, we should add that. And see whether there is a special rule (by KDE not Qt) for links in tooltips. I'll investigate. (PS: back from 2 weeks vacations, I'll have a look at the pending bugs in the coming days)
@Hugo What do you mean by "re-submit this bug report to Oxygen's color scheme"? There is no such component available on the list.
@pvxipygnw It's ok. I did it for you :) reassigned to "general" and added nuno in the cclist.
@pvxipygnw Could you provide, as attachment, a small tiny eclipse project that I can use to reproduce the issue ? I possibly have a fix but want to test before pushing. @Nuno Thing we need to do on KDE's side is to implement an appropriate ForegroundLink and ForegroundVisited color to the [Colors::Tooltip] section of kdeglobals, in our color change, that match the color well. Can you provide such a thing ? Hugo
hugo sure, if i know what we are tlking about excatly :)
Git commit 5a0361d32b3a22b3fe630fb2fbf9a981b1d4e75f by Hugo Pereira Da Costa. Committed on 17/09/2012 at 13:07. Pushed by hpereiradacosta into branch 'master'. Load html 'link' colors from kdeglobals M +33 -0 src/oxygenqtsettings.cpp M +3 -0 src/oxygenqtsettings.h http://commits.kde.org/oxygen-gtk/5a0361d32b3a22b3fe630fb2fbf9a981b1d4e75f
Created attachment 74012 [details] Tiny eclipse project with warning
Created attachment 74013 [details] Very complicated tooltip Tooltip with scrollbars in debug mode.
@hugo I've attached simple Eclipse Java project with one warning. By the way you said: "tooltips are not supposed to be interacted with". In debug mode there are even more interactive tooltips. They can include scorllbars and clickable "trees" as shown in the 4th screenshot. Moreover (this is not shown directly) these tooltips can be resized. Maybe it can have some meaning.
Git commit 0f74e08717903710969d09bb5b3fbc68a722f5a8 by Hugo Pereira Da Costa. Committed on 17/09/2012 at 13:07. Pushed by hpereiradacosta into branch 'master'. Load html 'link' colors from kdeglobals M +33 -0 src/oxygenqtsettings.cpp M +3 -0 src/oxygenqtsettings.h http://commits.kde.org/oxygen-gtk/0f74e08717903710969d09bb5b3fbc68a722f5a8
Thanks for the details. I modified the color settings in my oxygen color scheme and now the Eclipse tooltips look usable. You have marked this bug with the commit ID. Which release will you fix show up in? I am currently on KDE 4.10.1
@Ritesh Raj Sarraf The commit relates to oxygen-gtk (which is the theme used by ecclipse, as a Gtk-like application). As such, it is not shipped with KDE. you need to check the version of oxygen-gtk2 that you have installed (usually provided by your distro), and see if this is the latest version. Latest realease for oxygen-gtk2 is 1.3.2 (in fact, 1.3.2.1) and should have the fix included ... except that ... it is not enough. One also needs a fix to the Oxygen color scheme, this time shipped by KDE. But this part has not been fixed yet, as far as I know. (hence keeping the bug open) Hugo
(In reply to comment #16) Thank you for the explanation Hugo. On my Debian box, they correspond to gtk[2|3]-engines-oxygen package. Here, right now, it is at version 1.2.4. But I can live with the workaround for now, which is to modify the oxygen color scheme in System Settings
With gtk2-engine-oxygen 1.4.0 on OpenSUSE 13.1 RC1/x86_64 and KDE 4.11 I still get the display from attachment 73499 [details] .
Created attachment 83008 [details] Javadoc hover with unreadable link - OpenSUSE 13.1, gtk2-engine-oxygen 1.4.0
IIRC the gnome adwaita theme has received some changes for the 3.6.3 version related especially to Eclipse/SWT usage. I think that the relevant commit is https://git.gnome.org/browse/gnome-themes-standard/commit/?h=gnome-3-6&id=dd8a2d30920e3e19b4f9f9ae8e54b6b4b49dabc3 and the bug references are https://bugzilla.gnome.org/show_bug.cgi?id=688285 https://bugs.eclipse.org/bugs/show_bug.cgi?id=381010
@Robert, thanks for the link to Adwaita patch. I agree it is related to the issue at hand and will port that to oxygen-gtk. Will keep you posted.
Ping? If there's any way I can help, please let me know. I can try submitting a patch, but I wouldn't know where to start...
Dear Bug Submitter, This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond. Thank you for helping us make KDE software even better for everyone!
Dear Bug Submitter, This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand. Thank you for helping us make KDE software even better for everyone!
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!
This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone!