Bug 305761 - okular and strigi aren't actually optional
Summary: okular and strigi aren't actually optional
Status: RESOLVED NOT A BUG
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-25 14:46 UTC by Heiko Becker
Modified: 2013-01-06 19:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
patch to fix the above issue (1.25 KB, patch)
2012-08-25 14:48 UTC, Heiko Becker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Becker 2012-08-25 14:46:13 UTC
I didn't find mobipocket under products, so I filed it under okular.

Specifying -DBUILD_okular:BOOL=FALSE still builds the mobipocket okular plugin. The attached patch fixes that

Reproducible: Always
Comment 1 Heiko Becker 2012-08-25 14:48:13 UTC
Created attachment 73463 [details]
patch to fix the above issue
Comment 2 Albert Astals Cid 2012-08-27 20:06:25 UTC
Errr, specifying -DBUILD_okular=FALSE correctly disables okular from the build for me

kdeunstable@xps:~/build/kdegraphics-mobipocket:$ cmake -DBUILD_okular=FALSE ~/kdegraphics-mobipocket/
-- The C compiler identification is GNU
-- The CXX compiler identification is GNU
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Looking for Q_WS_X11
-- Looking for Q_WS_X11 - found
-- Looking for Q_WS_WIN
-- Looking for Q_WS_WIN - not found.
-- Looking for Q_WS_QWS
-- Looking for Q_WS_QWS - not found.
-- Looking for Q_WS_MAC
-- Looking for Q_WS_MAC - not found.
-- Found Qt-Version 4.8.1 (using /usr/bin/qmake)
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so;/usr/lib/x86_64-linux-gnu/libXft.so;/usr/lib/x86_64-linux-gnu/libXau.so;/usr/lib/x86_64-linux-gnu/libXdmcp.so;/usr/lib/x86_64-linux-gnu/libXpm.so
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so;/usr/lib/x86_64-linux-gnu/libXft.so;/usr/lib/x86_64-linux-gnu/libXau.so;/usr/lib/x86_64-linux-gnu/libXdmcp.so;/usr/lib/x86_64-linux-gnu/libXpm.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found X11: /usr/lib/x86_64-linux-gnu/libX11.so
-- Looking for include files CMAKE_HAVE_PTHREAD_H
-- Looking for include files CMAKE_HAVE_PTHREAD_H - found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE 
-- Looking for _POSIX_TIMERS
-- Looking for _POSIX_TIMERS - found
-- Found Automoc4: /usr/bin/automoc4 
-- Found Perl: /usr/bin/perl 
-- Found Phonon: /usr/include/qt4 
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Performing Test HAVE_FPIE_SUPPORT
-- Performing Test HAVE_FPIE_SUPPORT - Success
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test __KDE_HAVE_GCC_VISIBILITY
-- Performing Test __KDE_HAVE_GCC_VISIBILITY - Success
-- Found KDE 4.10 include dir: /home/kdeunstable/instalado/include
-- Found KDE 4.10 library dir: /home/kdeunstable/instalado/lib
-- Found the KDE4 kconfig_compiler preprocessor: /home/kdeunstable/instalado/bin/kconfig_compiler
-- Found automoc4: /usr/bin/automoc4
-- Found Strigi: /usr/lib/libstreams.so 

-----------------------------------------------------------------------------
-- The following external packages were located on your system.
-- This installation will have the extra features provided by these packages.
-----------------------------------------------------------------------------
   * okular - Provides an Okular backend for Mobipocket documents
   * strigi libraries - Provide a strigi analyzer for Mobipocket documents

-----------------------------------------------------------------------------
-- Congratulations! All external packages have been found.
-----------------------------------------------------------------------------

-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    KDE4_BUILD_TESTS


-- Build files have been written to: /home/kdeunstable/build/kdegraphics-mobipocket
kdeunstable@xps:~/build/kdegraphics-mobipocket:$ ccmake .


kdeunstable@xps:~/build/kdegraphics-mobipocket:$ make
-- Found Qt-Version 4.8.1 (using /usr/bin/qmake)
-- Found X11: /usr/lib/x86_64-linux-gnu/libX11.so
-- Found KDE 4.10 include dir: /home/kdeunstable/instalado/include
-- Found KDE 4.10 library dir: /home/kdeunstable/instalado/lib
-- Found the KDE4 kconfig_compiler preprocessor: /home/kdeunstable/instalado/bin/kconfig_compiler
-- Found automoc4: /usr/bin/automoc4

-----------------------------------------------------------------------------
-- The following external packages were located on your system.
-- This installation will have the extra features provided by these packages.
-----------------------------------------------------------------------------
   * okular - Provides an Okular backend for Mobipocket documents
   * strigi libraries - Provide a strigi analyzer for Mobipocket documents

-----------------------------------------------------------------------------
-- Congratulations! All external packages have been found.
-----------------------------------------------------------------------------

-- Configuring done
-- Generating done
-- Build files have been written to: /home/kdeunstable/build/kdegraphics-mobipocket
Scanning dependencies of target mobithumbnail_automoc
[  0%] Built target mobithumbnail_automoc
Scanning dependencies of target mobithumbnail
[ 12%] Building CXX object thumbnailers/CMakeFiles/mobithumbnail.dir/mobithumbnail_automoc.o
[ 25%] Building CXX object thumbnailers/CMakeFiles/mobithumbnail.dir/__/lib/mobipocket.o
/home/kdeunstable/kdegraphics-mobipocket/lib/mobipocket.cpp: In member function ‘void Mobipocket::DocumentPrivate::parseEXTH(const QByteArray&)’:
/home/kdeunstable/kdegraphics-mobipocket/lib/mobipocket.cpp:233:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
[ 37%] Building CXX object thumbnailers/CMakeFiles/mobithumbnail.dir/__/lib/decompressor.o
[ 50%] Building CXX object thumbnailers/CMakeFiles/mobithumbnail.dir/mobithumbnail.o
Linking CXX shared module ../lib/mobithumbnail.so
[ 50%] Built target mobithumbnail
Scanning dependencies of target mobi_automoc
[ 50%] Built target mobi_automoc
Scanning dependencies of target mobi
[ 62%] Building CXX object strigi/CMakeFiles/mobi.dir/mobi_automoc.o
[ 75%] Building CXX object strigi/CMakeFiles/mobi.dir/__/lib/mobipocket.o
/home/kdeunstable/kdegraphics-mobipocket/lib/mobipocket.cpp: In member function ‘void Mobipocket::DocumentPrivate::parseEXTH(const QByteArray&)’:
/home/kdeunstable/kdegraphics-mobipocket/lib/mobipocket.cpp:233:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
[ 87%] Building CXX object strigi/CMakeFiles/mobi.dir/__/lib/decompressor.o
[100%] Building CXX object strigi/CMakeFiles/mobi.dir/mobiendanalyzer.o
Linking CXX shared module ../lib/strigila_mobi.so
[100%] Built target mobi
Comment 3 Albert Astals Cid 2012-08-29 18:22:28 UTC
Setting to waiting for info since it works for me
Comment 4 Albert Astals Cid 2013-01-06 19:57:38 UTC
4 months and no answer, closing as invalid.

If you can still reproduce please reopen the bug.