Bug 305492 - Wrong (real) .. location (auto-suggestions) shown in copy/move windows, while in a directory symlink; wrong drag-and-drop moving to .. from dir symlink
Summary: Wrong (real) .. location (auto-suggestions) shown in copy/move windows, while...
Status: CONFIRMED
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on: 371748
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-20 14:21 UTC by pterodactyle
Modified: 2018-05-06 00:15 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pterodactyle 2012-08-20 14:21:39 UTC
When I'm in a directory symlink (like ~/video/movies/) and want to move a file or a directory to ../documentaries/ through the "Move" function (F6), after I type in ../, subdirectories of the real location of said directory appear (subdirectories of /mnt/new/download/ in my case). Nevertheless, if I leave .. as target, it gets moved to ~/video/ (which is right).
Please fix the wrong auto-suggestions
Also, if I move to .. through drag-and-drop, it actually lands in real "upper dir" (/mnt/new/download/) instead of symlink's upper dir (~/video/)
Please fix that as well.

Reproducible: Always

Steps to Reproduce:
1. Go to directory symlink
2. Choose a file, Press F6 or F5
3. Type in ../, look for auto-suggestions
----
1. Go to directory symlink
2. Choose a file, drag-and-drop to .., Choose "Move" or "Copy"
Actual Results:  
I - Autosuggestions for real upper dir, moving to symlink's upper dir
---
II - Moving to real upper dir

Expected Results:  
I - Autosuggestions for and moving to symlink's upper dir
---
II - Moving to symlink's upper dir

Arch Linux, Krusader 2.4.0beta1-6
KDE 4.8.4-1 (Fluxbox used, though)
Comment 1 Alex Bikadorov 2016-10-26 20:18:06 UTC
Confirmed. Links are always resolved for file operations before resolving relative paths.
This order must be changed.
And additionally the auto-suggestion.
Comment 2 Alex Bikadorov 2016-10-27 15:54:31 UTC
I can manually change the url after it was entered so that relative paths are resolved before symbolic links.

But the url completion/suggestion is made internally in KF5 (KUrlCompletion). I asked for an API enhancement...
Comment 3 Alex Bikadorov 2016-10-27 16:20:59 UTC
Git commit 94e4c2cb5216885619b8c99afdb8741f28389e9e by Alexander Bikadorov.
Committed on 27/10/2016 at 16:08.
Pushed by abikadorov into branch 'vfs_rework'.

Resolve relative path before symlinks in destination URL for copy/move and drop operations

M  +19   -6    krusader/VFS/default_vfs.cpp
M  +1    -0    krusader/VFS/default_vfs.h

http://commits.kde.org/krusader/94e4c2cb5216885619b8c99afdb8741f28389e9e