Bug 305333 - Closing Dragonplayer while playback makes it re-appear for a brief moment
Summary: Closing Dragonplayer while playback makes it re-appear for a brief moment
Alias: None
Product: phonon-backend-gstreamer
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 4.6-git
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Harald Sitter
: 306750 (view as bug list)
Depends on:
Reported: 2012-08-17 13:59 UTC by Kai Uwe Broulik
Modified: 2014-04-27 14:05 UTC (History)
17 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.7


Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2012-08-17 13:59:33 UTC
[using KDE 4.9.0 with Phonon Gstreamer 4.6.2]
When closing Dragonplayer whilt it is playing a file, it closes and briefly reappears (playing the video with sound) and then finally closes. (Tested only with mp4 files but it happens with all of them)

Reproducible: Always
Comment 1 Myriam Schweingruber 2012-08-20 14:32:12 UTC
And which dragonplayer version do you use? Please ALWAYS state the version of the product as well.
Comment 2 Kai Uwe Broulik 2012-08-20 14:35:19 UTC
Comment 3 Christoph Feck 2012-08-20 22:39:33 UTC
The version information is stated in the bug report.
Comment 4 Myriam Schweingruber 2012-08-21 06:08:09 UTC
(In reply to comment #3)
> The version information is stated in the bug report.

Now it is, the version field was not set initially :)
Comment 5 Adria 2012-09-04 23:01:32 UTC
I have the same issue with dragonplayer 4.9.1 and phonon-gstreamer 4.6.2.
Do you want me to provide some extra information?
Comment 6 Michail 2012-09-10 19:19:45 UTC
Also having this issue with 4.9.0 on 12.04.
Comment 7 Harald Sitter 2012-09-13 15:54:26 UTC
*** Bug 306750 has been marked as a duplicate of this bug. ***
Comment 8 Augusto 2012-09-21 14:34:35 UTC
I get this error message. Dragon player (4:4.9.1-0ubuntu1 ~ ~ ubuntu12.04.1 PPP1)
Comment 9 Torrie Fischer 2012-09-22 15:14:43 UTC
(In reply to comment #8)
> I get this error message. Dragon player (4:4.9.1-0ubuntu1 ~ ~ ubuntu12.04.1
> PPP1)

Erm, which error message are you referring to?
Comment 10 Torrie Fischer 2012-09-22 17:44:58 UTC
Git commit 2db4c430740da89fb22319b2ded63e770f3d6fac by Trever Fischer.
Committed on 22/09/2012 at 19:41.
Pushed by tdfischer into branch 'master'.

Use a sync connection to update the xvimagesink window handle

M  +1    -1    gstreamer/videowidget.cpp

Comment 11 Michail 2012-09-22 19:01:16 UTC
Thanks for fixing (:
When could we expect the update to become available in the repos?
Comment 12 optiluca@gmail.com 2013-01-14 23:14:45 UTC
I am still getting this with KDE 4.9.5, dragon player 2.0, phonon-gstreamer-4.6.2.  Is this meant to be fixed?
Comment 13 Rex Dieter 2013-01-14 23:24:26 UTC
The fix is committed and will be included in the next release of phonon-gstreamer (not done yet)
Comment 14 abveritas 2013-02-01 16:17:14 UTC
This issue was fixed with this commit, it was used as a patch on phonon-backend-gstreamer 4.6.2:
New version, 4.6.3, does not contain this fix, so the bug is still there, patch from the above linked commit still applies cleanly, and fixes the issue.
Comment 15 Matteo Italia 2013-05-02 01:36:55 UTC
I applied the patch to the phonon-gstreamer used in Ubuntu 13.04 ("phonon-backend-gstreamer-4.7.0really4.6.3"), but it seems to be only a workaround for the video part: the spurious video window does not appear, but the audio is still there.
Comment 16 Mustafa Muhammad 2013-10-13 23:06:14 UTC
This problem still exist in Kubuntu 13.10 beta 2 as of today (October 14, 2013),
is it fixed upstream? only the video as Matteo Italia said or it really fix the probelm?
Comment 17 Rex Dieter 2013-10-13 23:47:39 UTC
Yes it is fixed upstream, no new release has been made yet that includes it, so if your distro hasn't backported the fix, you will indeed still experience it.
Comment 18 Matteo Italia 2013-10-13 23:49:44 UTC
Uhm, when I posted that comment I applied the very patch referenced above on the Ubuntu 13.04 phonon backend, obtaining the result cited above; so, if the audio part is fixed upstream, it must come from another commit.
Comment 19 Rex Dieter 2013-10-14 00:22:44 UTC
Sorry, I only answered the first part of his question and the $SUBJECT of this bug (about the video portion re-appearing).  I'd suggest opening a new bug about the audio (imho)
Comment 20 michaelaquilina@gmail.com 2013-12-09 18:46:55 UTC
I have also noticed this on Kubuntu 13.10 64bit

Dragon Player version = 2.0
Using KDE Development Platform = 4.11.2
Comment 21 Daniel Vrátil 2014-04-08 18:04:50 UTC
Git commit 2cafb9db34ed1079eca22c913a48011b67ff9c70 by Dan Vrátil.
Committed on 08/04/2014 at 17:46.
Pushed by dvratil into branch '4.7'.

Only call QApplication::syncX() from the main thread

This fixes a regression introduced in 2db4c4. In order to pass WID to gstreamer
synchronously, a Qt::DirectConnection between Pipeline signal and a VideoWidget
slot must be created. However the signal from Pipeline can be emitted from an
arbitrary thread, so we can't call QApplication::syncX() directly from the slot
callchain. This patch moves the call to VideoWidget::syncX() slot that is called
from X11Renderer via queued invocation to make sure it's always executed from the
main thread.

FIXED-IN: 4.7.3
Related: bug 327367, bug 332977

M  +13   -0    gstreamer/videowidget.cpp
M  +1    -0    gstreamer/videowidget.h
M  +5    -14   gstreamer/x11renderer.cpp

Comment 22 Aru Sahni 2014-04-27 14:05:12 UTC
I'm experiencing this problem w/ Dragon Player 2.0 and KDE 4.13 (under Kubuntu Trusty). Will the bugfix be shipped with the 4.13.1 release?