Bug 304838 - If I enter and immedialtely exit from some folder, Dolphin will reopen that folder by itself after a second or two
Summary: If I enter and immedialtely exit from some folder, Dolphin will reopen that f...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: panels: terminal (show other bugs)
Version: 2.1
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: reproducible
: 306107 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-08-09 08:00 UTC by Damir Prebeg
Modified: 2012-09-19 07:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Damir Prebeg 2012-08-09 08:00:16 UTC
If I try to do fast navigation (enter to and immediate exit from folder), Dolpih will reopen folder that I've just exited by it self after second or two.

Reproducible: Always

Steps to Reproduce:
1. Open Dolphin
2. If it shows default home folder (/home/user) select (for eg.) Documents folder
3. Press enter and after 1/2 of second press Backspace
Actual Results:  
Wait a sec... Dolphin will return back to lastly viewed folder (in this case Documents) folder by it self

Expected Results:  
Dolphin should stay in current folder view regardles how fast one navigates.
Comment 1 Frank Reininghaus 2012-08-09 11:30:35 UTC
Thanks for the bug report!

Do you use the Terminal Panel? Does the bug disappear if you disable the Terminal Panel?

I can't test it at the moment, but I think the cause of the bug might be that 'cd' commands in the Terminal Panel (some of which are created automatically by Dolphin to keep the Terminal's directory in sync with the view) cause URL changes in the view, see bug 156732.
Comment 2 Damir Prebeg 2012-08-09 12:12:49 UTC
Hi Frank, my bad, I've didn't noticed that I have terminal open at all. It vas completely colapsed (shrinked) to bottom. And I've tested, you'r right. Terminal 'cd-ing' causes the problem.
Comment 3 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:22:29 UTC
Resetting assignee to default as per bug #305719
Comment 4 Frank Reininghaus 2012-09-01 11:45:53 UTC
Thanks for the feedback, can confirm the issue.
Comment 5 Frank Reininghaus 2012-09-01 11:46:31 UTC
*** Bug 306107 has been marked as a duplicate of this bug. ***
Comment 6 Frank Reininghaus 2012-09-19 07:29:31 UTC
Git commit 9111135f2c5343e4e09828e805ea8d152e527914 by Frank Reininghaus.
Committed on 19/09/2012 at 09:28.
Pushed by freininghaus into branch 'KDE/4.9'.

Prevent unwanted URL changes when using the Terminal Panel

The root cause of the problem was that TerminalPanel's member
m_konsolePartCurrentDirectory, which is used to determine in
TerminalPanel::sendCdToTerminal(QString& dir) if the Konsole part's
directory is aleady 'dir', such that issuing the 'cd' command is not
needed, was updated too late, namely when the part's
currentDirectoryChanged(QString) signal was received, which may be up
to one second after the 'cd' command.

When changing the directory from "dir1" to "dir2" and going back to
the "dir1" in less than one second (either by using the 'Back' action
or by activating a tab which still had "dir1" open), the 'cd dir1'
command was therefore suppressed because the Terminal Panel still
thought that "dir1" was the current directory in the part. However,
the directory of the part was actually "dir2", and when the
currentDirectoryChanged(QString) signal was received from the part, the
view's URL was set to "dir2" as well.
Related: bug 306349
FIXED-IN: 4.9.2

M  +1    -0    dolphin/src/panels/terminal/terminalpanel.cpp

http://commits.kde.org/kde-baseapps/9111135f2c5343e4e09828e805ea8d152e527914