Bug 304822 - TitleHeight should never be smaller than ButtonHeight
Summary: TitleHeight should never be smaller than ButtonHeight
Alias: None
Product: kwin
Classification: Plasma
Component: aurorae (show other bugs)
Version: 4.9.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 4.9.1
Assignee: Martin Flöser
URL: https://git.reviewboard.kde.org/r/105...
Keywords: regression
Depends on:
Reported: 2012-08-08 20:13 UTC by eric.erfanian
Modified: 2012-08-17 18:37 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.1
mgraesslin: ReviewRequest+

Window Screenshot (765.90 KB, image/png)
2012-08-08 20:14 UTC, eric.erfanian
Maximized window screenshot (126.29 KB, image/png)
2012-08-08 20:14 UTC, eric.erfanian

Note You need to log in before you can comment on or make changes to this bug.
Description eric.erfanian 2012-08-08 20:13:37 UTC
Upgraded to 4.9, using window decoration FormaN.

Window title text now renders high and is exacerbated when maximizing a window. Text renders fine using Plastik.

See screenshot attachments.

Reproducible: Always

Steps to Reproduce:
1. Switch to window decoration theme FormaN

Actual Results:  
2. Title bar text now displayed incorrectly.

Expected Results:  
Title bar text should be centered.

4.9 Arch packages. OpenGL. Not sure if this is something that needs to be fixed with the decoration itself. Worked fine in 4.8.
Comment 1 eric.erfanian 2012-08-08 20:14:12 UTC
Created attachment 73054 [details]
Window Screenshot
Comment 2 eric.erfanian 2012-08-08 20:14:35 UTC
Created attachment 73055 [details]
Maximized window screenshot
Comment 3 Thomas Lübking 2012-08-08 20:32:52 UTC
It seems to only affet that particular decoration here
(no other aurorae deco that i've tried shows this)

Might be "intended" (anchors top) - last update of the deco is ~2 months ago. Sure your former version was newer?
Comment 4 eric.erfanian 2012-08-08 20:38:16 UTC
I'm fairly confident it is the same window decoration version from 4.8 to 4.9, unless there is some automatic update pull through GHNS.
Comment 5 Martin Flöser 2012-08-08 20:48:35 UTC
Most likely a bug in the theme (there are a few themes which are rather broken). The theme engine got rewritten for 4.9 so it is possible that it is now stricter concerning some things.
Comment 6 eric.erfanian 2012-08-08 20:54:08 UTC
Okay, thanks for the info. I will switch to a different decoration in the mean time.
Comment 7 Thomas Lübking 2012-08-08 20:55:10 UTC
remove the "TitleHeight=12" (seems the only cause) key and maybe also inform the author.
Comment 8 Martin Flöser 2012-08-08 21:09:39 UTC
it's actually a bug in Aurorae (at least according to my own documentation of the theme format). The titleHeight in this case is too small, but it could also be a small check like:
height: Math.min(auroraeTheme.titleHeight, auroraeTheme.buttonHeight + auroraeTheme.buttonMarginTop)
Comment 9 Martin Flöser 2012-08-08 21:17:45 UTC
You can change the file aurorae.qml on your system according to the diff posted in the review request to fix this issue till 4.9.1 is released.
Comment 10 Martin Flöser 2012-08-17 18:37:44 UTC
Git commit beaf0e633577ce4c3bc9ac1b0834167bd9c7922e by Martin Gräßlin.
Committed on 08/08/2012 at 23:14.
Pushed by graesslin into branch 'KDE/4.9'.

Ensure that titleHeight is at least height of buttons

Required to properly lay out the title in case of vertical or
bottom alignment.
FIXED-IN: 4.9.1
REVIEW: 105937

M  +1    -1    kwin/clients/aurorae/src/qml/aurorae.qml