Bug 304740 - SearchExpansion Filter makes no sense editing incoming messages
Summary: SearchExpansion Filter makes no sense editing incoming messages
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: text-ui-message-filters (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-07 16:28 UTC by David Edmundson
Modified: 2013-03-03 21:11 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Edmundson 2012-08-07 16:28:23 UTC
In the original design search expansion filter was to update outgoing messages to replace "gg:whatever" wtih "http://google.com/?search=whatever"

Right now we only process incoming messages, which makes this 100% pointless, as you'll see the nice link, but the person you're chatting to won't.

Even if they run KTp, you can't assume they have the same web shortcuts.
Comment 1 Lasath Fernando 2013-03-03 21:11:52 UTC
Git commit ef1247efb3e16e089f44194f1af7a95377a073b7 by Lasath Fernando.
Committed on 03/03/2013 at 21:46.
Pushed by fernando into branch 'master'.

Rename preprocessMessage to processOutoingMessage

Since preprocessMessage didn't really make it clear that it was
supposed to deal with outgoing messages.

REVIEW: 109255

M  +1    -1    KTp/message-processor.cpp
M  +1    -1    KTp/message-processor.h

http://commits.kde.org/telepathy-common-internals/ef1247efb3e16e089f44194f1af7a95377a073b7