Bug 304563 - Akregator 4.9.0 handles keyboard input badly when focus is on article list
Summary: Akregator 4.9.0 handles keyboard input badly when focus is on article list
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: 4.9
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-04 16:19 UTC by Frank Steinmetzger
Modified: 2012-08-13 08:19 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Steinmetzger 2012-08-04 16:19:07 UTC
Dear devs

Starting with 4.9.0, Akregator introduces different (and IMHO wrong) behaviour when the focus is on the article list:

When pressing cursor up/down, the previous/next article is shown. This should not happen because:
- cursor left/right are assigned to those actions by default. Cursor up/down are not assigned, and hence they should not trigger them.
- it is common practice in programs like this (such as KMail and KNode), to have cursor up/down instead scroll the article, regardless of where the keyboard focus is (which was also Akregator's behaviour before 4.9)

Konqueror offers to use vi-like shortcuts such as j/k to scroll down/up, respectively. This worked nicely in the 4.8 series, but now, the article doesn't scroll anymore, only the article list jumps around its centre when pressing j.

Thanks for your consideration.

Reproducible: Always

Steps to Reproduce:
- Click on an article in the article list.
- Press cursor up/down
Actual Results:  
The previous/next article is shown.

Expected Results:  
The shown article should scroll up/down.

Some would say that the new behaviour is more intuitive (because if the article list is focused, then all keyboard input should affect that list). However, it is less practical because that way it becomes impossible to fully navigate a feed with the keyboard only.
Comment 1 Allen Winter 2012-08-10 12:35:21 UTC
CCing Lê Hoàng Phương 

this might be the result of a change he made recently.
Comment 2 Lê Hoàng Phương 2012-08-10 14:06:37 UTC
Hi. Actually the new behavior has solved some bugs related to being not able to navigate in the article list by keyboard. What you need to do is to press Tab and Shift Tab to move the focus back and forth between the article list and the article viewer.
Comment 3 Frank Steinmetzger 2012-08-11 01:55:45 UTC
Well, using Cursor left/right has always worked to navigate the article list. After all, they're the default shortcut for the respective actions.

Just to illustrate my use case (and I realise it's *my* use case, others may handle it differently of course):
I don't read in Akregator that often (every other day or so), but when I do, I skim through dozens, sometimes hundreds of articles. To get through them quickly, the left hand lies on the cursor block (to scroll an article I'm interested in) and right shift (to range-select a bunch of articles in the article list, so I can delete them). The right hand sits on the mouse. That way I can very quickly and efficiently navigate through the feed, read the interesting stuff and delete the rest.

My reasoning is all about saving time when reading. To reach for Tab, I would have to move the hand over the entire keyboard twice for every article I want to read. It sounds plain lazy, but if summed up, this amounts to a lot of time. And using the mouse to set the keyboard focus back and forth also takes much longer than simply pressing a key which is focus-independent. (I just tried tab/shift-tab, and it doesn't work for some feeds, like heise.de and golem.de; the focus gets trapped in the HTML document. It would also not work if I clicked a link in there).

Don't get me wrong, I appreaciate that finally, after a long time, Akregator gets some new attention. And if you don't want to bring the old cursor up/down behaviour back for the old geezers like me who used them since KDE3 times, I can't force you to, just to satisfy my need for nostalgia.

But then I'd like to ask you to repair the j/k behaviour that got broken in the process. Right now, j scrolls down the article list with wrap-around, and k seems to do nothing at all.

Cheers and have a nice weekend.
Comment 4 Marc ct 2012-08-11 18:22:54 UTC
Hello,

I am absolutely agree with Frank. This behaviour exists since _almost_ the begginig of the time. This new behaviour is also annoying for me. I think that the old behaviour is much more efficient and should not be change, IMHO. 
I don't really know the detail of these bugs related for change this behaviour, but sounds like them could be resolved just telling them to use 'cursor left/right', like here is suggesting to press tab and shift+tab. Well.. yes.. now with these new behaviour everyone knows how to move in the article list. 

Akregator is part of kontact as kmail is. So if this behaviour is changed in akregator then for coherence it should be change also in kmail. (thing that I would like not to see.. :-) )

One of the things that I most loved of akregator (and kmail) is this _old_ behaviour with these keys, I felt so proud of this comparing with others. 

Cheers.
Marc
Comment 5 Lê Hoàng Phương 2012-08-13 08:07:30 UTC
I'm really sorry as I didn't anticipate this problem when I made the change. So now the commit exposes more problems than what it fixed. I'll revert the change and find other way to fix those old bugs rather than just enabling the focus on the Artice List.

OT: Akregator is already a good software to read feeds. I just want to use some of my spare time to hunt some bugs for it. I'm not a really good programmer so traversing through its codebase always give me a headache to figure out how things work under the UI. I think it also needs a new modern UI by QML as this guy suggested: http://kdeblog.mageprojects.com/.
Comment 6 Lê Hoàng Phương 2012-08-13 08:19:23 UTC
Git commit 8be38c6fc3028c79a7a4bd12d97bb5b41fdf93ae by Lê Hoàng Phương.
Committed on 13/08/2012 at 10:08.
Pushed by lehoang into branch 'KDE/4.9'.

revert commit 488641aba372ff9397a8a6ed8031c18b14bfbbc6

The commit breaks the usability feature in old akregator: use up, down button to navigate up and down the article viewer
FIXED-IN: 4.9.1

M  +1    -1    akregator/src/mainwidget.cpp

http://commits.kde.org/kdepim/8be38c6fc3028c79a7a4bd12d97bb5b41fdf93ae