Bug 304551 - jumping inner folder window when switching between folder tree and places panel
Summary: jumping inner folder window when switching between folder tree and places panel
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: bars: location (show other bugs)
Version: 17.08.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Christoph Feck
URL:
Keywords: reproducible
Depends on:
Blocks:
 
Reported: 2012-08-04 13:16 UTC by Gernot Wieprecht
Modified: 2017-09-03 00:29 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gernot Wieprecht 2012-08-04 13:16:38 UTC
I encountered a strange behaviour in dolphin: When I switch from places panel to tree panel or back the inner folder window of dolphin jumps. That is very irritating.

Reproducible: Always

Steps to Reproduce:
1. Put places panel and folder tree in the sidebar
2. Switch between both and watch the file window
3. The inner window/the files jump up or down when you use the other panel.


Expected Results:  
The inner window and the files should keep the position when you switch from one panel to the other.
Comment 1 Janet 2012-08-04 16:13:16 UTC
I can confirm this behaviour. It happens because the addressbar changes its height. When you use the tree there is an icon before the address (showing the places in a menu) and if you use the places it isn't. This icon has the size of the small icons. So the address bar has the heigth of the small icons when you open the tree panel and the height of the text when you use the places panel. I don't like that behaviour either, I agree it is very confusing and disturbing when suddenly the files jump without obvious/needed reason. The address bar should always have the same height, no matter which panel is used.
Comment 2 Janet 2012-08-04 16:14:57 UTC
I have to correct myself: the icon in front of the address bar does *not* use the small icons size, only the space needed for the icon does!
Comment 3 Frank Reininghaus 2012-08-07 16:05:04 UTC
Thanks for the bug report! One possible solution would be to only show the "Places" icon in the location bar if the Places Panel is disabled (and not just hidden by the Folders Panel).
Comment 4 Gernot Wieprecht 2012-08-07 17:19:16 UTC
I wasn't aware of the cause, thanks Janet. 

Frank Reinighaus, your proposal sounds reasonable. It does make sense not to show the icon for the places menu in case the places panel already is there, either as extra tab or in a shared panel. I guess, I like that solution.

Janet brought another aspect into discussion, not related to the jumping: the size of the icon which claims the space of a "small icon" but itself is only in fixed 16 size. Is another report needed for that?
Comment 5 Frank Reininghaus 2012-08-07 20:45:45 UTC
(In reply to comment #4)
> Janet brought another aspect into discussion, not related to the jumping:
> the size of the icon which claims the space of a "small icon" but itself is
> only in fixed 16 size. Is another report needed for that?

Yes, one report for each issue. But please describe exactly what the bug is, I did not quite get it from what you wrote above.
Comment 6 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:19:59 UTC
Resetting assignee to default as per bug #305719
Comment 7 Gernot Wieprecht 2012-09-22 15:32:00 UTC
(In reply to comment #5)
> Yes, one report for each issue. But please describe exactly what the bug is,
> I did not quite get it from what you wrote above.

I did my best to describe it - better I hope: Bug 307215
Comment 8 Christoph Feck 2012-09-23 03:46:40 UTC
This is caused by the PlacesSelector button using a sizeHint as if it had a frame. On the other hand, the widget should have a fixed height (maximum of line edit height and button's height). Will look into it.
Comment 9 Christoph Feck 2012-09-23 11:36:06 UTC
If the icon size is larger than the text height, the widget would waste space when only the text and none of the icons is visible. Would that be acceptable?
Comment 10 Janet 2012-09-23 12:19:20 UTC
in reply of Comment 9:
For me it would be ok, because IMHO the breadcrumb bar is very tight fit around the text which makes it look very compressed . It could benefit from a little more space at the top and bottom. This also would solve the "jumping" when you have small icons in size 32 and switch between breadcrumbs and editable location bar.
Comment 11 Nate Graham 2017-09-02 21:16:42 UTC
I'm not able to reproduce the issue in Dolphin 16.12.3 or 17.08.0. The location bar is now the same height for both Places and Folders panels, so the jumpt behavior doesn't happen. It looks like the fix for https://bugs.kde.org/show_bug.cgi?id=307215 may have fixed this issue.
Comment 12 Christoph Feck 2017-09-03 00:29:13 UTC
It is "fixed" by Breeze (and the new Oxygen) having larger margins for QLineEdit than Oxygen from KDE4.