Bug 303692 - kdesrc-build should support custom make command
Summary: kdesrc-build should support custom make command
Status: RESOLVED FIXED
Alias: None
Product: kdesrc-build
Classification: Developer tools
Component: general (other bugs)
Version First Reported In: Git
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Michael Pyne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-17 17:06 UTC by Michael Pyne
Modified: 2024-05-10 09:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Pyne 2012-07-17 17:06:07 UTC
It seems the ninja make system might soon be The New Hotness now that CMake 2.8.9 seems to support it. With that in mind there's probably no better time than the present to finally implement custom make commands...

It would require a custom build and custom install command but hopefully not too much past that.
Comment 1 Michael Pyne 2012-07-28 23:12:46 UTC
Git commit 9d0f34cefd1f7233cc90cf3f17b8566a280dd3f8 by Michael Pyne.
Committed on 18/07/2012 at 00:56.
Pushed by mpyne into branch 'master'.

Add custom build command option.

Unfortunately I was not able to split out moving safe_make and
run_make_command with the actual implementation of this option
after-the-fact. Whoops.

This should implement support for a custom build command (and custom
install command, assuming the install can be performed by adding
'install' to the command line).

Hopefully that will be sufficient for 'ninja' or other buildsystems.
Note that this only changes the *build* command, the other parts of the
build system still needs to be supported in kdesrc-build (for now,
custom build systems probably wouldn't be too hard to implement if
necessary).

Assuming your proposed command is available in PATH and can be called
like make, doing something like this should suffice:

module (or module-set) foo
    custom-build-command ninja
end module (or module-set)

M  +18   -0    doc/index.docbook
M  +209  -177  kdesrc-build

http://commits.kde.org/kdesrc-build/9d0f34cefd1f7233cc90cf3f17b8566a280dd3f8
Comment 2 David Faure 2015-02-22 13:14:40 UTC
Any chance for this to work as a global option as well?
Comment 3 Michael Pyne 2015-02-22 23:40:12 UTC
It already does, at least for me.
Comment 4 David Faure 2015-02-26 08:03:02 UTC
Oh. You're right. Testing error. Thanks!
Comment 5 Michael Pyne 2024-05-10 09:16:11 UTC
Git commit 382afa11df63fd8924ea891165540d5327e6d74b by Michael Pyne.
Committed on 28/07/2012 at 23:12.
Pushed by ashark into branch 'docbook_historied_per_file'.

Add custom build command option.

Unfortunately I was not able to split out moving safe_make and
run_make_command with the actual implementation of this option
after-the-fact. Whoops.

This should implement support for a custom build command (and custom
install command, assuming the install can be performed by adding
'install' to the command line).

Hopefully that will be sufficient for 'ninja' or other buildsystems.
Note that this only changes the *build* command, the other parts of the
build system still needs to be supported in kdesrc-build (for now,
custom build systems probably wouldn't be too hard to implement if
necessary).

Assuming your proposed command is available in PATH and can be called
like make, doing something like this should suffice:

module (or module-set) foo
    custom-build-command ninja
end module (or module-set)

Original commit: 9d0f34ce
https://invent.kde.org/sdk/kdesrc-build/-/commit/9d0f34cefd1f7233cc90cf3f17b8566a280dd3f8

M  +18   -0    doc/kdesrc-buildrc/conf-options-table.docbook

https://invent.kde.org/sdk/kdesrc-build/-/commit/382afa11df63fd8924ea891165540d5327e6d74b