Bug 303667 - Add a Nepomuk/Vocabulary header
Summary: Add a Nepomuk/Vocabulary header
Status: RESOLVED FIXED
Alias: None
Product: nepomuk
Classification: Miscellaneous
Component: libnepomukcore (show other bugs)
Version: git master
Platform: unspecified Linux
: NOR task
Target Milestone: ---
Assignee: Nepomuk Bugs Coordination
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2012-07-17 10:06 UTC by Vishesh Handa
Modified: 2012-09-26 13:06 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/nepomuk-core/a8bbd4f64c3752774490a7de0ac00e9323977403
Version Fixed In:

Attachments
patch file that creates includes/Vocabulary.h (826 bytes, patch)
2012-08-30 20:50 UTC, evair 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Vishesh Handa 2012-07-17 10:06:42 UTC 
We have ontology header files for all of the Nepomuk ontologies.

* Nepomuk/Vocabulary/PIMO
* Nepomuk/Vocabulary/NIE
* Nepomuk/Vocabulary/NFO
* Nepomuk/Vocabulary/NCO
* etc

It would be nice to have a header "Nepomuk/Vocabulary" which includes all the vocabulary header files.

Relevant Code: nepomuk-core/includes/
Comment 1 evair 2012-08-30 20:50:10 UTC 
Created attachment 73567 [details]
patch file that creates includes/Vocabulary.h

Created a file includes/Vocabulary.h and CMakeLists.txt was modified to install the first file.
The Vocabulary.h contains the headers (.h) included by files inside directory vocabulary.
Comment 2 Vishesh Handa 2012-08-30 20:57:45 UTC 
(In reply to comment #1)
> Created attachment 73567 [details]
> patch file that creates includes/Vocabulary.h
> 
> Created a file includes/Vocabulary.h and CMakeLists.txt was modified to
> install the first file.
> The Vocabulary.h contains the headers (.h) included by files inside
> directory vocabulary.

Hey Evair

Thanks a lot for the patch. Couple of minor points, if you don't mind.
* Could you please use all lower case for the file - vocabulary.h - I know the bug report says otherwise, but that's my fault.
* Also, would it be possible for you to move it from the includes directory to the libnepomukcore directory?

Thanks a lot.

Btw, do you have a developer account?
Comment 3 evair 2012-09-15 03:45:42 UTC 
The changes were made in the header. The fix is in the following URL: https://git.reviewboard.kde.org/r/106435/
Comment 4 Vishesh Handa 2012-09-26 13:06:37 UTC 
Git commit a8bbd4f64c3752774490a7de0ac00e9323977403 by Vishesh Handa.
Committed on 25/09/2012 at 13:00.
Pushed by vhanda into branch 'master'.

LibNepomukCore: Add a vocabulary.h header

This header is added as a convenience, so that you don't have to include
all the individual vocabulary headers.

Patch contributed by Evair Severo <evairsevero@gmail.com>
REVIEW: 106435

M  +1    -0    libnepomukcore/CMakeLists.txt
A  +11   -0    libnepomukcore/vocabulary.h     [License: UNKNOWN]  *

The files marked with a * at the end have a non valid license. Please read: http://techbase.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page.


http://commits.kde.org/nepomuk-core/a8bbd4f64c3752774490a7de0ac00e9323977403