Bug 303665 - Port to QDBusConnection::call in ResourceData
Summary: Port to QDBusConnection::call in ResourceData
Status: RESOLVED FIXED
Alias: None
Product: nepomuk
Classification: Unmaintained
Component: libnepomukcore (show other bugs)
Version: git master
Platform: unspecified Linux
: NOR task
Target Milestone: ---
Assignee: Nepomuk Bugs Coordination
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2012-07-17 09:53 UTC by Vishesh Handa
Modified: 2012-11-30 18:31 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Vishesh Handa 2012-07-17 09:53:23 UTC 
The ResourceData class currently uses KJobs in order to perform the low level tasks such as addProperty, removeProperty and setProperty.

Since the KJobs are not synchronous, ResourceData runs a local event loop and waits till it finishes. Running a local event loop is bad practice. It would be better to have a blocking call via QDbusConnection::call( .. ).

Relevant Code: nepomuk-core/libnepomukcore/resource/resourcedata.cpp

The arguments will have to be passed in a QDBusMessage.