Bug 303382 - Port the nepomuksearch kiosalve to the Query::ResultIterator
Summary: Port the nepomuksearch kiosalve to the Query::ResultIterator
Status: RESOLVED FIXED
Alias: None
Product: nepomuk
Classification: Unmaintained
Component: kioslave - nepomuksearch (show other bugs)
Version: git master
Platform: unspecified Linux
: NOR task
Target Milestone: ---
Assignee: Sebastian Trueg
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2012-07-11 18:01 UTC by Vishesh Handa
Modified: 2012-11-27 12:51 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/kde-runtime/dcc2a510d7678fc9f28912918609c844f6048368
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Vishesh Handa 2012-07-11 18:01:18 UTC 
The nepomuksearch kio slave explicitly uses the ResourceManager::mainModel() to run a sparql query and then extracts the results from the Soprano::QueryResultIterator into Nepomuk2::Query::Result.

This entire process can be replaced by the Query::ResultIterator.

Relevant Code: kde-runtime/nepomuk/kioslaves/search/searchfolder.cpp
Relevant Functions: SearchFolder::list() and SearchFolder::extractResult(..)
Comment 1 Vishesh Handa 2012-11-27 12:51:45 UTC 
Git commit dcc2a510d7678fc9f28912918609c844f6048368 by Vishesh Handa.
Committed on 27/11/2012 at 13:40.
Pushed by vhanda into branch 'master'.

Nepomuk Search KIO Slave: Port to the Query::ResultIterator

No point duplicating code.

REVIEW: 107466
CCMAIL: poetabh@gmail.com

Patch contributed by Gabriel Poesia <poetabh@gmail.com>

M  +3    -36   nepomuk/kioslaves/search/searchfolder.cpp
M  +0    -2    nepomuk/kioslaves/search/searchfolder.h

http://commits.kde.org/kde-runtime/dcc2a510d7678fc9f28912918609c844f6048368