Bug 302787 - If no configure-flags are specified kdesrc-build failes with no hints
Summary: If no configure-flags are specified kdesrc-build failes with no hints
Status: RESOLVED WORKSFORME
Alias: None
Product: kdesrc-build
Classification: Developer tools
Component: general (other bugs)
Version First Reported In: 1.15
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Michael Pyne
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2012-06-30 10:56 UTC by Dario Cambié
Modified: 2018-10-27 04:15 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Proposed patch (521 bytes, patch)
2012-06-30 10:57 UTC, Dario Cambié
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dario Cambié 2012-06-30 10:56:40 UTC
If the "configure-flags" of the qt module are mistakenly left commented then compiling qt fails with no error messages in the log and just this text in the console:

"Use of uninitialized value in split at /usr/bin/kdesrc-build line 3876."

A more detailed error messages should be provided for easily debug of the problem.

Reproducible: Always

Steps to Reproduce:
1. Comment "configure-flags" lines in kdesrc-buildrc
2. Execute kdesrc-build qt
3. Open the build log file: it's empty
Actual Results:  
"Use of uninitialized value in split at /usr/bin/kdesrc-build line 3876."

Expected Results:  
Warning: compile-flags is undefined! This is hardly what you want: check your configuration file (e.g. ~/.kdesrc-buildrc)!
Comment 1 Dario Cambié 2012-06-30 10:57:07 UTC
Created attachment 72233 [details]
Proposed patch
Comment 2 Michael Pyne 2012-07-03 00:48:39 UTC
The patch works, but I would prefer to continue if configure-flags are left blank (under the assumption the user wants that behavior).

However, the return value of getOption() at that point shouldn't be undefined, it should be empty (i.e. '') if the option isn't set, since configure-flags is also defined as a global option.

Even then, Perl should still have split undef with a warning (that you saw) and at least tried to run configure. Was there any other log output (e.g. configure.log)? If leaving options off completely would cause the build to fail I'd prefer to know what options are required so that information could be given in the error message. Right now telling the user that the configuration file is incorrect doesn't help them figure out the right option to specify.
Comment 3 Michael Pyne 2013-01-14 01:52:11 UTC
Updating status.
Comment 4 Andrew Crouthamel 2018-09-24 02:16:23 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Andrew Crouthamel 2018-10-27 04:15:44 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!