Bug 302474 - Only emit tick sound on releasing mouse cursor
Summary: Only emit tick sound on releasing mouse cursor
Status: RESOLVED FIXED
Alias: None
Product: kmix
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Christian Esken
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-25 01:00 UTC by Kai Uwe Broulik
Modified: 2021-03-05 20:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2012-06-25 01:00:08 UTC
In KDE 4.9 KMix now does a ticking sound when changing volume. When dragging the slider in the popup, it should only emit the sound when releasing mouse cursor, not while dragging.

Reproducible: Always
Comment 1 Jonathan Marten 2021-03-01 18:33:30 UTC
Git commit 5749abf20cbcde1c84d7d1e56431ebc5c33daf3c by Jonathan Marten.
Committed on 01/03/2021 at 18:06.
Pushed by marten into branch 'master'.

Make the volume feedback implementation common to all backends

Using a new singleton class VolumeFeedback, which receives volume
change events via a ControlManager announcement and plays the sound
for a volume change on the current global master device.  This also
handles rate limiting and stopping at maximum volume as per the
referenced bugs.  Remove the corresponding code from the PulseAudio
and ALSA backends.

In theory this means that volume feedback will also work with OSS,
assuming that Canberra supports OSS output.
Related: bug 302361, bug 323608

M  +6    -1    CMakeLists.txt
M  +12   -15   apps/kmixwindow.cpp
M  +1    -5    apps/kmixwindow.h
A  +243  -0    apps/volumefeedback.cpp     [License: LGPL (v2+)]
A  +64   -0    apps/volumefeedback.h     [License: LGPL (v2+)]
M  +0    -111  backends/mixer_alsa9.cpp
M  +3    -12   backends/mixer_alsa9.h
M  +7    -73   backends/mixer_pulse.cpp
M  +0    -2    backends/mixer_pulse.h

https://invent.kde.org/multimedia/kmix/commit/5749abf20cbcde1c84d7d1e56431ebc5c33daf3c
Comment 2 Jonathan Marten 2021-03-05 20:34:37 UTC
The previous commit should have addressed the problem - the feedback sound does not actually take account of the mouse button being down over the slider, but there is a minimum delay which means that continuous sounds do not merge into one.  Please reopen the bug if this does not seem to be working or if there is still a problem.