Bug 302288 - Rename the "close" option
Summary: Rename the "close" option
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 2.0.5
Platform: Microsoft Windows Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-21 09:26 UTC by Grégoire Verlut
Modified: 2012-07-06 22:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Grégoire Verlut 2012-06-21 09:26:54 UTC
"File > close" is not self explanatory, since Kst handles only one file per running instance.
I would rename this "close" to "new session"

Reproducible: Always
Comment 1 Netterfield 2012-07-05 05:37:25 UTC
This option both closes the current session and creates a new one.  So neither name is fully 'self explanatory'.  And neither name is wrong.

How about 'Close/New' ?
Comment 2 Nicolas Brisset 2012-07-05 23:08:40 UTC
I'm all for "New Session". As long as Kst asks whether the user wants to save his changes before throwing everything away, there is no risk IMHO.
I think Close/New is clumsy and Close alone is not clear: which file(s) will it close (datasources, .kst, ...) and what will happen to Kst?

I would almost commit it right now... so that we can close the bug and get it into 2.0.6. Good for our statistics :-) But I'll wait for some feedback.

By the way, when using this action I often get a Kst crash not too long after. I fear we don't really reset everything properly. But that should go into a different bug report.
Comment 3 Nicolas Brisset 2012-07-06 22:22:10 UTC
SVN commit 1304398 by brisset:

Rename the "Close" File menu entry to "New Session", which is less confusing.
I checked that when there are unsaved changes the user gets a chance to save them :-)


 M  +2 -2      mainwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1304398