Bug 302256 - We should remember if there is some unread message when user logs out
Summary: We should remember if there is some unread message when user logs out
Status: RESOLVED UNMAINTAINED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: general (show other bugs)
Version: git-latest
Platform: unspecified Linux
: NOR normal
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-20 19:16 UTC by Daniele E. Domenichelli
Modified: 2024-09-18 18:13 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:
kde: Decision-Required+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele E. Domenichelli 2012-06-20 19:16:35 UTC
When you log out, if you have some unread message, you won't be able to read them when you log in (unless you check the log viewer)
When ktp is started we should display the unread messages like if we just received them
Comment 1 David Edmundson 2012-06-20 19:23:55 UTC
Any idea how?

Do you know if these messages are ack'ed or not?
Comment 2 Martin Klapetek 2012-06-20 21:19:01 UTC
I'm moving this to 0.5 milestone as the stable branch does not receive any new features.
Comment 3 David Edmundson 2012-10-25 15:33:03 UTC
All agree we should. Still needs a good proposal on how. 

Please add plans to this post.
Comment 4 Daniel Vrátil 2012-10-25 16:44:42 UTC
My rough and highly idealistic proposal: The approver could list of channelId (that's accountId+contactId) and timestamps of first unread message on each channel. On shutdown the list would be stored somewhere and on start up the approver would just read the list, query logger for message count since the timestamp and display the "incoming conversation(s)" tray icon.

The question is how to force ktp-text-ui to load specific message count. Normally ktp-text-ui connects to an existing channel and displays all messages in the channel, but after restart the channel does not exist so we could probably add a DBus method to ktp-text-ui to open channel with specified contact and load specified amount of messages from the logger.
Comment 5 David Edmundson 2013-03-20 01:47:43 UTC
Alternate plan: We block logout if there are unread messages? Like Kate does for an unsaved file.
Comment 6 Daniele E. Domenichelli 2013-03-20 10:28:26 UTC
Sounds like a good idea, but before allowing logout, we should also set all the accounts offline, or we still be subject to race conditions
Comment 7 Martin Klapetek 2013-03-20 12:12:22 UTC
That breaks "restore presence on login" no?
Comment 8 Daniele E. Domenichelli 2013-03-20 12:15:46 UTC
Probably. We should disable that as well! :D
Comment 9 Dennis Schridde 2013-04-06 10:25:07 UTC
I dislike the idea of blocking logout. Instead I like the idea about loading messages from the logger.
Comment 10 Dennis Schridde 2013-04-06 10:25:44 UTC
P.S: Alternatively you could store the unread messages separately and just display that file on next boot.
Comment 11 Daniele E. Domenichelli 2013-04-06 11:15:51 UTC
does the logger store if a message was read or not?
How does empathy handle this?
Comment 12 Daniel Vrátil 2013-04-06 15:41:07 UTC
@Danielle: Nope. And I don't think there's any concept of read or unread messages in Tp at all.
Comment 13 David Edmundson 2013-04-06 15:42:54 UTC
There is in Telepathy, the handler has to "acknowledge" each user to say the user has seen it.
If we don't do this and close the channel mission-control presents the channel again.

I agree that TelepathyLoggerQt doesn't have it.
Comment 14 David Edmundson 2013-04-06 16:00:54 UTC
Has this actually been a problem? Or is it purely a hypothetical one?

I don't  see it as much different to when we receive a message when we're offline .
Comment 15 Martin Klapetek 2013-04-06 20:09:11 UTC
The question is what happens to a message waiting in to-be-approved channel when mission-control/channel dispatcher quits (ie. a restart). Is it stored locally and recreated after restart or refetched from server upon reconnecting (the case of being offline) or is it just lost (the server thinks it was delivered)?
Comment 16 Justin Zobel 2021-03-09 07:25:46 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.
Comment 17 Christoph Cullmann 2024-09-18 18:13:00 UTC
Dear user, unfortunately Telepathy is no longer maintained.

Please migrate to another solution, e.g. for Jabber a possibility is Kaidan, for Matrix a candidate is NeoChat.