Git Version: e4e135c Fix images not showing after viewing a video
When thumbnailing a folder for which gwenview hasn't created thumbnails yet, the thumbnailer keeps running after exiting gwenview. This is at least an annoying behaviour since this blocks unmounting of flash drives, etc.
I marked this as critical since it might be possible that the user won't notice that unmounting had failed and therefore he would remove his external device (-> data loss?).
Steps to Reproduce:
1. Open a folder for which gwenview has not created thumbnails yet.
2. When gwenview starts to thumbnail the images, hit control+q or similar to exit it
3. main window disappears
A gwenview process keeps running and thumbnailing all the images in the queue.
Gwenview should have exited immediately.
Created attachment 71892 [details]
The patch deletes the ThumbnailLoadJob when ThumbnailView is deleted.
I agree it is a problem, but your patch just caused an assert here:
ASSERT: "qMetaTypeGuiHelper" in file /home/aurelien/kdesrc/qt/src/corelib/kernel/qmetatype.cpp, line 1384
libpng error: Write Error
gwenview(7376) Gwenview::storeThumbnailToDiskCache: Could not save thumbnail
QFile::at: Cannot set file position 0
KCrash: crashing... crashRecursionCounter = 2
KCrash: Application Name = gwenview path = /home/aurelien/opt/k4m/bin pid = 7376
I think we need a safer way to stop the job. I think clearing the item list in the job destructor would be a better fix.
Created attachment 72860 [details]
wait for sThumbnailCache to finish
I think ThumbnailLoadJob has to wait for sThumbnailCache to finish. I don't know why, but somehow the QImage that is to be stored to disk seems to disappear (sometimes).
Git commit 3dbd4e95c9494d4ae5ed51ebfbfa75efeceff97f by Aurélien Gâteau, on behalf of Benni Hill.
Committed on 02/08/2012 at 18:06.
Pushed by gateau into branch 'KDE/4.9'.
Stop thumbnailing when Gwenview exits.
This is important as it blocks unmounting of flash drives.
M +1 -0 lib/thumbnailloadjob.cpp
M +1 -0 lib/thumbnailview/thumbnailview.cpp