Bug 301691 - Dolphin context menu display can be so large that the entire screen is covered.
Summary: Dolphin context menu display can be so large that the entire screen is covered.
Status: RESOLVED FIXED
Alias: None
Product: kdiff3
Classification: Applications
Component: application (show other bugs)
Version: unspecified
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: michael
URL:
Keywords:
: 362091 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-06-11 22:19 UTC by zanetu
Modified: 2021-08-13 21:29 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Lengthy "Save file:///blah-blah for later" menu item. (18.04 KB, image/png)
2012-06-11 22:19 UTC, zanetu
Details
Height is normal yet width spans the entire screen (kdiff3 v1.7.90 and dolphin v18.08.0; Jan 15, 2019). (45.99 KB, image/png)
2019-01-15 08:07 UTC, Zane Tu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description zanetu 2012-06-11 22:19:49 UTC
Created attachment 71746 [details]
Lengthy "Save file:///blah-blah for later" menu item.

Please see the attached screenshot. 

Steps to reproduce: 
1. Launch Dolphin. 
2. Right-click on a file with a long name, preferably containing non-ASCII characters. 
3. Select "KDiff3 ..." in the context menu. 

Expected result: 
The sub-menu pop-up does not cover the entire screen.

Actual result: 
The sub-menu pop-up covers the entire screen due to the lengthy "Save file:///blah-blah for later" menu item. 

Causes of this bug, in my opinion, are as follows. 
1. Kdiff3 context menu plugin cannot display non-ASCII characters (eg Chinese) correctly and uses lengthy percent-encoding instead. 
2. Kdiff3 context menu plugin displays too much information regarding the file that is selected, i.e. the entire file path. Since the file is already highlighted in Dolphin upon right-click, the file name is not required to be displayed in the context menu, let alone the entire file path. 

Possible fixes: 
Option 1: Replace the menu item "Save file:///blah-blah for later" with "Save this file for later".
Option 2: Display non-ASCII characters correctly in context menu and replace the menu item "Save file:///blah-blah for later" with "Save blah-blah for later".
Comment 1 zanetu 2012-06-11 22:21:47 UTC
Version info: 
KDiff3 v0.9.96 (64 bit)
Debian Wheezy (Unstable) 
Linux 3.2.0-2-amd64
Comment 2 zanetu 2019-01-15 01:31:46 UTC
Seems fixed in v1.7.90. 

Version info: 
KDiff3 v1.7.90 (64-bit)
Dolphin v18.08.0 
Debian sid (Unstable) 
Related bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801680
Comment 3 michael 2019-01-15 01:58:47 UTC
Has the long file name issue been fix?

This bug is about an issue with the contextually menu being too large if file with a very long name is selected. The contextually menu not showing https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801680 was caused by kdiff3 not being ported to kf5. The code is ported now however nothing has been done yet to directly address the long file name issue. These are not the same issue.

Also please be patient as this code had been sitting un-maintained for several years. So in addition to old bugs needing fixed there's been a lot a clean up to do. This includes removing some now obsolete code. This is on my todo list.
Comment 4 Zane Tu 2019-01-15 08:07:31 UTC
Created attachment 117463 [details]
Height is normal yet width spans the entire screen (kdiff3 v1.7.90 and dolphin v18.08.0; Jan 15, 2019).

I mentioned https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801680 because I was not able to invoke the pop-up menu at all until that bug got fixed.

I added a screenshot to show the long name issue being (partially?) fixed in kdiff3 v1.7.90 and dolphin v18.08.0. The height of pop-up menu is limited to what it should be whereas the width still spans the entire screen, which is acceptable to me somehow.
Comment 5 michael 2021-02-18 18:57:11 UTC
I have take some steps to try and improve the situation from kdiff3's side. Local files will no longer be displayed in url encoded from. This can not be avoided for a remote urls. The "Save" option will show only the name of the selected file. Hopefully that will be enough otherwise this may have to go to the frameworks/qt people as that is where the menu is actually displayed.
Comment 6 michael 2021-08-13 21:29:37 UTC
*** Bug 362091 has been marked as a duplicate of this bug. ***