Edit: Even if it did do something this code is broken.

It's loaded by default to "false" then only changed to the config value if the config changes.

Just installed 4.9 Beta 2 (4.8.90) and the battery widget lost some functionality for me.
I have a notebook with 2 batteries and the old widget (4.8.4) shows the percentage of both and when added to the desktop (not systray) it shows two battery icons, one for each battery available.
Now with the new widget both doesn't work anymore. It's a fairly big regression for me.

How about showing the average charge percent of all batteries in the popup dialog and separate charge percent of each battery in the applet tooltip?

(In reply to comment #3)
I just made some screen-shots to compare the old widget with the new widget.
Especially I like the behavior of the old widget on the desktop: showing two battery icons. (see desktop.png). So it would be nice to have this in the new widget too.
> How about showing the average charge percent of all batteries in the popup
> dialog and separate charge percent of each battery in the applet tooltip?
If I understood your comment correctly you want to make the tooltip like the old one (tooltip.png). That's fine for me.
The old widget also showed both percentages in the popup (see systray.png).

So my wish would be that the behavior on the desktop will be the same as in the old one.
And for tooltip and/or systray it doesn't really matter for me where it is, it just should be possible to see the percentages of both batteries. To have it in the tooltip as well as in the popup would be the optimal solution, but if that's too hard to implement it also would be ok for me to have it in either the tooltip or the popup.

Created attachment 71836 [details]
Old widget on desktop.

Created attachment 71837 [details]
Old widget in systray.

Created attachment 71838 [details]
Old widget's tooltip.

Created attachment 71839 [details]
New widget on desktop for comparison.

Created attachment 71840 [details]
New widget in systray for comparison.

For what it's worth, Viranch has created a patch for this, and IIRC, it's pure QML, so easy to test.

The patch is a bit too scary for 4.9 in this phase though, so it won't be in 4.9.0. If Dominik could test it, that would help, however.

(In reply to comment #10)
> For what it's worth, Viranch has created a patch for this, and IIRC, it's
> pure QML, so easy to test.

For QML it's simply applying the patch and reloading the applet?

> The patch is a bit too scary for 4.9 in this phase though, so it won't be in
> 4.9.0. If Dominik could test it, that would help, however.

I can test it but I have to know where it is :-). Having a link would be nice.

(In reply to comment #11)
> For QML it's simply applying the patch and reloading the applet?

Yes.

> I can test it but I have to know where it is :-). Having a link would be
> nice.

Here: https://git.reviewboard.kde.org/r/105277/diff/

(In reply to comment #12)
> (In reply to comment #11)
> Here: https://git.reviewboard.kde.org/r/105277/diff/

Sorry for the late reply, somehow bugzilla didn't notified my of you comment so I saw it just today.
Anyway this diff doesn't apply on top of RC2, and as 4.9 will be released today afternoon/evening (IIRC) I will have that soon (maybe even today, or more likely tomorrow) so it would be cool if you could rebase it on top of that.

(In reply to comment #13)
> Sorry for the late reply, somehow bugzilla didn't notified my of you comment
> so I saw it just today.
> Anyway this diff doesn't apply on top of RC2, and as 4.9 will be released
> today afternoon/evening (IIRC) I will have that soon (maybe even today, or
> more likely tomorrow) so it would be cool if you could rebase it on top of
> that.

Here's the rebased patched: http://sprunge.us/UTTW
I generated the diff on top of KDE/4.9 git branch.

(In reply to comment #14)
> Here's the rebased patched: http://sprunge.us/UTTW
> I generated the diff on top of KDE/4.9 git branch.

Thanks, I can't comment on the code, but from a users POV this works the way I wanted it to work :)
And it is even superior to the old one, nice!

Again thanks a lot for your work.

(In reply to comment #15)
> Thanks, I can't comment on the code, but from a users POV this works the way
> I wanted it to work :)
> And it is even superior to the old one, nice!
> 
> Again thanks a lot for your work.

Thanks for the quick testing. I'll soon put it up on kde-look.org so others can use it until the feature is shipped.

Thanks for the patch. it works partly but only the icon in the notification updates. the battery percentage does not update itself in the popup if i click on it. Would someone fix this? I am unable to fix it on my own.

Well, this patch mostly works for me. I'm seeing the same thing as Sebastian.

We are past 4.9.1 now, any news on this?

(In reply to comment #19)
> We are past 4.9.1 now, any news on this?

Yes, working on it, will push the fix tonight.

Git commit 90db8129ff19ec7ce9e0ef294ae7e8a8e9398f7c by Viranch Mehta.
Committed on 08/09/2012 at 02:16.
Pushed by viranch into branch 'master'.

Implement support for multiple batteries in battery
monitor applet
REVIEW: 105277

A  +77   -0    plasma/generic/applets/batterymonitor/contents/code/logic.js
M  +18   -12   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml
M  +73   -68   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml

http://commits.kde.org/kde-workspace/90db8129ff19ec7ce9e0ef294ae7e8a8e9398f7c

Thanks Viranch Mehta ! :)

I think this bug is also related to #253453 "with two batteries, remaining time is calculated for the discharging battery only" ( https://bugs.kde.org/show_bug.cgi?id=253453 ) and #304510 "Battery plasmoid does not show remaining time" ( https://bugs.kde.org/show_bug.cgi?id=304510 ).

We could not reproduce these 2 bugs and we don't know if they are fixed or not. Also, I suspect that the power management system of KDE was sometime disturbed because of these bugs.
Do we have some news on this topic ?

(In reply to comment #22)
> I think this bug is also related to #253453 "with two batteries, remaining
> time is calculated for the discharging battery only" (
> https://bugs.kde.org/show_bug.cgi?id=253453 ) and #304510 "Battery plasmoid
> does not show remaining time" ( https://bugs.kde.org/show_bug.cgi?id=304510
> ).

I'm not sure why #253453 was there in the first place, but if you think its not the case anymore, feel free to close it, because according to the latest code, the remaining time should be correct one.

#304510 is now a feature request since the plasma developers decided to remove the remaining time feature due to the inaccuracy of the same.

> We could not reproduce these 2 bugs and we don't know if they are fixed or
> not. Also, I suspect that the power management system of KDE was sometime
> disturbed because of these bugs.
> Do we have some news on this topic ?

I'm sorry I'm not aware of that.

The bug is marked as "fixed in 4.9.2", but the fix seems not to be included in 4.9.2 or 4.9.3. Any chance this will end up in 4.9.x some time soon?

(In reply to comment #24)
> The bug is marked as "fixed in 4.9.2", but the fix seems not to be included
> in 4.9.2 or 4.9.3. Any chance this will end up in 4.9.x some time soon?

Can you still reproduce this after cleaning your $HOME/.kde/ folder (or just removing the plasma*rc files from $HOME/.kde/share/config/)? The folder might be named $HOME/.kde4/.. on some systems BTW

The last time I looked the required fix was simply not present in the 4.9.x
branch. So, clearing any config files won't help...

The fix is still not present in 4.9.5. The fixes in https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/90db8129ff19ec7ce9e0ef294ae7e8a8e9398f7c work.

I've just had a look, it seems the fix was not backported to the KDE/4.9 branch at that time. It did go into KDE/4.10.

As there won't be any new releases of the 4.9 range, in order to receive this fix, update to Plasma Workspaces 4.10.

Thank you for verifying that the fix works, I don't have this kind of hardware available to test with, unfortunately.

I spoke too soon, the fixes in C#27 do work for a desktop plasmoid, however the systray no longer updates at all and bug #253453 is still an issue.

*** Bug 314207 has been marked as a duplicate of this bug. ***