Bug 301427 - Now Playing widget: Stop button should give visual response
Summary: Now Playing widget: Stop button should give visual response
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-nowplaying (show other bugs)
Version: 4.8.80 (beta1)
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Alex Merry
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-08 08:37 UTC by Janek Bevendorff
Modified: 2012-06-13 08:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.9


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Janek Bevendorff 2012-06-08 08:37:26 UTC
Currently Amarok has a very, very long fade-out when stopping tracks. Therefore the stop button is grayed out after clicking it so the user knows that the UI has reacted and Amarok is doing something.

The stop button on the Now Playing widget, however, is not grayed out. This is okay when it's used together with a player that has not fade-out, but in combination with Amarok it feels like the widget is unresponsive. Clicking the button should invoke a noticeable action immediately, i.e. the button should be grayed out/disabled.
Currently it stays active and when I click it, it takes a while until the track is faded out. Clicking the button twice, however, stops the track instantly making the button feels as if it wasn't doing anything on first click.

Reproducible: Always

Steps to Reproduce:
1. Add the Now Playing widget to your desktop
2. Play a song in Amarok
3. Stop it using the stop button on the Now Playing widget
4. Track should slowly start fading out, but you won't notice it for the first few seconds
5. Click the button a second time
6. Track stops immediately
Actual Results:  
Button feels like it isn't doing anything upon first click

Expected Results:  
Button should immediately show a visual response.
Comment 1 Alex Merry 2012-06-11 10:43:56 UTC
Git commit 1fdca98b83c465bf0cd63974553a8365fa7f67a9 by Alex Merry.
Committed on 11/06/2012 at 12:40.
Pushed by alexmerry into branch 'master'.

mpris2-dataengine: fake a CanStop capability

This allows the stop button to be greyed out when there is nothing to be stopped, making the user experience slightly less confusing.

M +10 -0 plasma/generic/dataengines/mpris2/playercontainer.cpp
M +4 -1 plasma/generic/dataengines/mpris2/playercontainer.h
M +1 -1 plasma/generic/dataengines/mpris2/playercontrol.cpp

http://commits.kde.org/kde-workspace/1fdca98b83c465bf0cd63974553a8365fa7f67a9
Comment 2 Alex Merry 2012-06-11 10:47:30 UTC
I've changed it so the widget will grey out the Stop button when the media player reports it is stopped.

Currently, Amaork reports it is still playing during fade-out, although it removes the track metadata, so it is clear _something_ has happened, as all the track information disappears (this is with Amarok from git master).  Given that pressing stop again _is_ a sensible option (to cancel the fade-out), I think this is the best compromise.

This should be fixed in 4.9 RC1.