Bug 301248 - Searching for previous match makes it impossible to search for new keyword
Summary: Searching for previous match makes it impossible to search for new keyword
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.13.2
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-05 22:26 UTC by Philipp Hartwig
Modified: 2012-07-11 20:58 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.9.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hartwig 2012-06-05 22:26:03 UTC
There is an oddness in the search behavior that bites me every day. It seems to be related to the use of the Previous button, but I might have observed it under different circumstances. The following steps should illustrate it.

Reproducible: Always

Steps to Reproduce:
1. You are in the middle of some document. Open the search bar, type some text that matches the current document and hit enter.
2. Hit the Previous button to find the previous match.
3a. Append some text to the text in the search bar and hit enter. Nothing happens. Using the Previous and Next buttons continues to search for the old text.
3b. If instead of adding text as in 3a. you remove text from the text in the search bar, hitting enter doesn't have any effect either, but at least the Previous and Next buttons seem to look for the new text.
Actual Results:  
The search bar and the enter button are now in some broken state and one needs to fiddle about with the buttons and the enter key to be able to fully functionally search for new text.

Expected Results:  
After modifying the text in the search bar, hitting enter should search for the new text.
Comment 1 Albert Astals Cid 2012-07-11 20:56:45 UTC
Git commit f7abc568bcafceeb97b1d5daa3424ac20f6aedd9 by Albert Astals Cid.
Committed on 11/07/2012 at 22:55.
Pushed by aacid into branch 'master'.

Correctly start a search if Return is pressed after a back search

FindNext was early quitting because the previous search was a back search and thus never got to startSearch, now we call startSearch if m_changed
FIXED-IN: 4.9.0

M  +4    -1    ui/searchlineedit.cpp

http://commits.kde.org/okular/f7abc568bcafceeb97b1d5daa3424ac20f6aedd9
Comment 2 Albert Astals Cid 2012-07-11 20:58:26 UTC
Git commit 1609de9fd51991214237a0bd9f97ea67657c60c9 by Albert Astals Cid.
Committed on 11/07/2012 at 22:55.
Pushed by aacid into branch 'KDE/4.9'.

Correctly start a search if Return is pressed after a back search

FindNext was early quitting because the previous search was a back search and thus never got to startSearch, now we call startSearch if m_changed
FIXED-IN: 4.9.0

M  +4    -1    ui/searchlineedit.cpp

http://commits.kde.org/okular/1609de9fd51991214237a0bd9f97ea67657c60c9