Bug 300986 - Cannot Build from Source - Amarok 2.5.90 (2.6 Beta)
Summary: Cannot Build from Source - Amarok 2.5.90 (2.6 Beta)
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.5.90 (2.6 beta)
Platform: unspecified Linux
: NOR major
Target Milestone: 2.6
Assignee: Amarok Developers
URL:
Keywords: regression, release_blocker
Depends on:
Blocks:
 
Reported: 2012-06-01 09:10 UTC by Pascalis Ligdas
Modified: 2012-08-10 22:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.6


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pascalis Ligdas 2012-06-01 09:10:26 UTC
Building the code fails at 96% with the following message :
...                                       
index.docbook:21: parser error : Entity 'ged.vertaald' not
defined                                                                                   
&ged.vertaald;&Rinse.Devries;&Antoon.Tolboom;&Freek.de.Kruijf;&Thom.Castermans; 
              ^
make[2]: *** [doc/nl/index.cache.bz2] Error 1
make[1]: *** [doc/nl/CMakeFiles/nl-handbook.dir/all] Error 2
make: *** [all] Error 2
[pascal@pascaLinux:~/Downloads/amarok-2.5.90/amarok-2.5.90-build]

Reproducible: Always

Steps to Reproduce:
1.cmake .. -DCMAKE_INSTALL_PREFIX=`kde4-config --prefix` -DCMAKE_BUILD_TYPE=debugfull
2.make
3.After 15mins or so of "building" the above error is reported.
Actual Results:  
[pascal@pascaLinux:~/Downloads/amarok-2.5.90/amarok-2.5.90-build] $make
...
[ 96%] Built target it-handbook
Scanning dependencies of target nl-handbook
[ 96%] Generating index.cache.bz2                                                                                                                    
index.docbook:21: parser error : Entity 'ged.vertaald' not defined                                                                                   
&ged.vertaald;&Rinse.Devries;&Antoon.Tolboom;&Freek.de.Kruijf;&Thom.Castermans; 
              ^
make[2]: *** [doc/nl/index.cache.bz2] Error 1
make[1]: *** [doc/nl/CMakeFiles/nl-handbook.dir/all] Error 2
make: *** [all] Error 2
[pascal@pascaLinux:~/Downloads/amarok-2.5.90/amarok-2.5.90-build] $


I know this is not a bug but I don't know any other way to build the code and actually test it. 

I apologize if you think I shouldn't report this here.
Comment 1 Myriam Schweingruber 2012-06-01 09:24:38 UTC
Which KDE version do you use? Probably the translation list is not up-to-date in your version.
Comment 2 Pascalis Ligdas 2012-06-01 09:39:35 UTC
Sorry, I forgot to mention I'using KDE 4.7.2 (openSUSE 12.1).
Comment 3 Bart Cerneels 2012-06-01 09:41:59 UTC
You can apply the following patch for building with KDE <= 4.6

http://mail.kde.org/pipermail/amarok-devel/attachments/20111226/24123473/attachment.diff

This is something that is usually handled by the packagers when they create amarok patches compiled to older KDE versions.
Comment 4 Bart Cerneels 2012-06-01 09:48:20 UTC
Correction. Thom.Castermans was added in 4.8, perhaps 4.7.3 if translations were actually updated during the bugfix release.
Comment 5 Myriam Schweingruber 2012-06-01 09:53:44 UTC
KDE 4.7.3 should work fine, the definition was added before that version and normally should be backported.
Comment 6 Pascalis Ligdas 2012-06-01 16:13:44 UTC
I removed the offending part (get.vertaald = par.translated) from the dutch index.docbook and it built smoothly.

Sorry. I cannot provide a real patch for it (I am not a developer).
Comment 7 Bart Cerneels 2012-06-03 08:07:06 UTC
New patch provided by Modestus Vainius:
http://mail.kde.org/pipermail/amarok-devel/attachments/20120603/e0158eae/attachment.diff

It might be exactly the same as the older one.
Comment 8 Matěj Laitl 2012-07-31 09:32:41 UTC
Reopen, real fix will follow.
Comment 9 Matěj Laitl 2012-07-31 09:43:27 UTC
SVN commit 1308660 by laitl:

Don't depend on XML entities from post kdelibs 4.6

Dear Dutch translation team, Amarok 2.6 (to be released soon) has
declared dependency on KDE 4.6, but you use XML entities in your Amarok
Handbook translation that come from kdelibs 4.7 and 4.8, namely:
KDE 4.8:
	&ged.vertaald;
KDE 4.7:
	&Thom.Castermans;
	&vertaling.thom;

...and it breaks building of Amarok on KDE 4.6 and 4.7 [1]. Please use
only entities from kdelibs up to version that is declared as Amarok's
minimal dependency. We will probably bump the dependency for Amarok 2.7
to KDE 4.7 or 4.8, so this patch may be (partially) reversed when it
happens.

[1] http://lists.kde.org/?l=amarok-devel&m=133867494717926&w=2

The actual fix is to declare the missing entities in the document, it
was tested that the redeclaration doesn't cause errors with newer
kdelibs. (confirmation pending) Patches originally provided by Modestas
Vainius.

Please CC amarok-devel@kde.org on any possible further discussion.

FIXED-IN: 2.6
CCMAIL: kde-i18n-nl@kde.org
CCMAIL: Modestas Vainius <modax@debian.org>
CCMAIL: Bart Cerneels <bart.cerneels@kde.org>

 M  +3 -0      index.docbook  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1308660
Comment 10 Matěj Laitl 2012-08-10 22:29:35 UTC
SVN commit 1310164 by laitl:

Re-add entities missing from KDE 4.6 to index.docbook

Guys, you broke the Amarok build *again*. Please see
http://websvn.kde.org/trunk/l10n-kde4/nl/docs/extragear-multimedia/amarok/?view=log
and especially http://websvn.kde.org/?view=revision&revision=1308660
for explanation.

You perhaps update this using a script, so please fix the script or the
source it generates the index.docbook from.

Please CC amarok-devel@kde.org on any possible replies.

CCMAIL: Freek de Kruijf <f.de.kruijf@gmail.com>
CCMAIL: kde-i18n-nl@kde.org
CCMAIL: amarok-devel@kde.org

 M  +3 -0      index.docbook  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1310164