Bug 300349 - Make ShaderManager act as a real stack
Summary: Make ShaderManager act as a real stack
Status: CONFIRMED
Alias: None
Product: kwin
Classification: Plasma
Component: compositing (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: 4.11
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-20 11:15 UTC by Thomas Lübking
Modified: 2021-03-10 07:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Lübking 2012-05-20 11:15:30 UTC
See eg. https://git.reviewboard.kde.org/r/104918/

The issue here is that the shadermanager just restores the used shader, but not the uniforms etc. so that if you push a shader, alter some uniforms and pop the shader, that does not mean you end up where you started. Instead you've to 
- store all uniforms you might touch
- push the shader again when done (to ensure you alter the right one and nothing else has currently pushed the other shader) and reset uniforms.
Comment 1 Justin Zobel 2021-03-10 00:12:34 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.
Comment 2 Thomas Lübking 2021-03-10 07:16:58 UTC
Not a bug bug code deficiency that lead to clumsy client code as illustrated by the patch in the (now 404) review link (was a fix by Martin to the desktop cube effect)