Bug 300247 - Allow hiding individual groups in new Places Panel
Summary: Allow hiding individual groups in new Places Panel
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: panels: places (show other bugs)
Version: 16.12.2
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: usability
: 303442 310041 313893 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-05-18 14:09 UTC by Kai Uwe Broulik
Modified: 2018-01-02 00:29 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2012-05-18 14:09:47 UTC
The new places panel features different categories, such as Places, Devices, Recently Accessed and Search For. Howver, I don’t need the Recently Accessed or Search For thingie and I’d like to be able to hide them because I more need my devices which are then at the bottom of the list (cannot be re-arranged either) and scrollbars are ugly :)
There should be a right-click menu that contains checkboxes for the individual categories.

Reproducible: Always

Steps to Reproduce:
1. Right click the places panel
Actual Results:  
A menu appears with
Add Entry
Unlock Panels

Expected Results:  
A menu appears with
2. Get a menu with
[  ] Places (well, this would actually make no sense to hide them)
[  ] Recently Used
[  ] Search For
[  ] Devices
---
Add Entry
Unlock Panel
Comment 1 Peter Penz 2012-05-18 14:31:43 UTC
It is too late 4.9 as no new strings are allowed, but probably this might make sense for 4.10 (I'm not sure yet). You currently can already hide the categories but it requires more efforts than your suggestion: You need to right-click on each item of a category and select "[x] Hide"
Comment 2 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:19:42 UTC
Resetting assignee to default as per bug #305719
Comment 3 Gernot Wieprecht 2012-10-23 22:23:55 UTC
I hope this will come very soon, I am very unhappy with the new places sidebar. I now have set my prefered icon size but suddenly new categories appeared which I don't need and which force the devices category out of sight so that I always have to scroll. Please add an option to hide the timeline and search entries - or at least to move them to the bottom.
Comment 4 Gernot Wieprecht 2012-10-23 22:28:23 UTC
I overlooked the hint to tick every single entry. Yes, that works, thanks. But hiding complete categories and moving them to a different position would be better.
Comment 5 Frank Reininghaus 2012-11-13 22:13:17 UTC
*** Bug 310041 has been marked as a duplicate of this bug. ***
Comment 6 Guillaume DE BURE 2012-11-27 21:48:34 UTC
What about moving "Recently Used" and "Search For" sections to a new panel ? This way, the user could decide whether he would like show it or not ?

Anyway, this bug gets my vote too :)
Comment 7 J.A. Moray 2012-11-27 22:01:48 UTC
The thing is that there are users that want one of those two options, and that way you have both or none, so I don't think it's the best solution.
Comment 8 Kai Uwe Broulik 2012-11-27 22:16:35 UTC
The way Mac OS Finder does it should be the best example: You can collapse each individual category by clicking on its title. Adding yet another panel is out of the question.
Comment 9 Janet 2012-11-28 16:19:16 UTC
(In reply to comment #8)
> The way Mac OS Finder does it should be the best example: You can collapse
> each individual category by clicking on its title. Adding yet another panel
> is out of the question.

That really would be the best IMHO. But then it also should be possible to move the collapsed categories to another position (bottom of panel), so that they don't waste space in the visible area of the panel.
Comment 10 Frank Reininghaus 2013-01-27 12:29:05 UTC
*** Bug 313893 has been marked as a duplicate of this bug. ***
Comment 11 Nate Graham 2017-09-03 02:05:39 UTC
*** Bug 303442 has been marked as a duplicate of this bug. ***
Comment 12 Nate Graham 2017-10-19 19:35:42 UTC
There is a patch winding its way through the review process that implements this feature: https://phabricator.kde.org/D8367
Comment 13 Nate Graham 2017-12-08 12:40:29 UTC
author	Franck Arrecot <franck.arrecot@kdab.com>	2017-11-22 09:06:35 (GMT)
committer	Franck Arrecot <franck.arrecot@kdab.com>	2017-12-08 10:57:05 (GMT)
commit	b8bd61c3650c8264b3d1f4751c8ec659109b13d3 (patch)
tree	84b97036ef22d8126eabdde316fd8c354aedda09
parent	cd9856d14552809251d11a5d0fc88d63928a7bab (diff)
User can now hide an entire places group from KFilePlacesView
Summary:
Through the ui the user can now right click on a place group
and request to hide it.

Note: It is not the collapsing solution, which would need a way bigger
effort on the model to be achieve but an intermediary solution that could
be useful for users.

Depends on D8367

Depends on D8948
Depends on D8947
Depends on D8946
Depends on D8945
Depends on D8944
Depends on D8943

BUG: 300247

Test Plan:
Manual testing with the ui.

{F5459735} (before hidden section)

{F5459734} (menu for hiding section)

{F5459733} (after hidden section)

Reviewers: ngraham, renatoo, ervin, mwolff, mlaurent

Reviewed By: renatoo, ervin, mwolff, mlaurent

Subscribers: mwolff, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D8450
Diffstat
-rw-r--r--	autotests/kfileplacesmodeltest.cpp	26	
		
-rw-r--r--	src/filewidgets/kfileplacesmodel.cpp	18	
		
-rw-r--r--	src/filewidgets/kfileplacesmodel.h	1	
		
-rw-r--r--	src/filewidgets/kfileplacesview.cpp	44	
		
4 files changed, 85 insertions, 4 deletions
Comment 14 Christoph Feck 2017-12-31 08:41:05 UTC
Above commit is for KPlacesView, but not for Dolphin, right?
Comment 15 Nate Graham 2017-12-31 16:42:52 UTC
The Places view and model were moved to KIO, and Dolphin has been refactored to use that. I can confirm that categories are now hide-able in Dolphin.
Comment 16 Christoph Feck 2018-01-02 00:29:28 UTC
Dolphin still has its own code for the places view. But you are right, there was a separate commit to add support for hiding groups also for Dolphin. Links below.

Commit: https://commits.kde.org/dolphin/5f1df43b87898b380228a3548553de3290ddb0d7

Code Review: https://phabricator.kde.org/D8855