Bug 298470 - Contact list and chat windows should use the same WM_CLASS
Summary: Contact list and chat windows should use the same WM_CLASS
Status: RESOLVED INTENTIONAL
Alias: None
Product: telepathy
Classification: Unmaintained
Component: contactlist (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: 0.6-next
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-20 07:26 UTC by Cédric Bellegarde
Modified: 2013-03-20 23:15 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Cédric Bellegarde 2012-04-20 07:26:00 UTC 
In docks like (icon task) task manager, there is no way to group contact list and chat window in the same launcher because they do not use the same WM_CLASS

Reproducible: Always

Steps to Reproduce:
1. Use icon-tasks plasmoid
2. Launche telepathy-contact-list and open a chat

Actual Results:  
Two icons in taskbar

Expected Results:  
One icon in taskbar
Comment 1 David Edmundson 2012-04-24 12:44:23 UTC 
Agreed. Startup WM_CLASS can be set in the .desktop file.

We should use the kwin ML if we have problems.
Comment 2 David Edmundson 2012-08-09 09:08:55 UTC 
I had a test with this, it didn't seem to make any difference, the desktop file only sets the startup WM_CLASS.

Needs discussion with KWin et al.
Comment 3 David Edmundson 2012-12-07 19:01:58 UTC 
Talked to Martin Grasslin, agreed that we should do this. 
This will now happen ASAP. We should also apparently set the wm_role per application to say contact list etc.

Sorry for the delays!
Comment 4 David Edmundson 2013-03-18 03:03:35 UTC 
Implemented: https://git.reviewboard.kde.org/r/109560/

I'm not convinced I like it.

I use icon-tasks, and have the contact list as one of the icons. With this patch if I close the contact list, it still associates it with the text ui, meaning I can't get the contact list back (through icon tasks) whilst I have a chat open.
Comment 5 David Edmundson 2013-03-20 23:15:18 UTC 
Tried it, it was really annoying. I'm not going to implement this.

If you want to use it yourself, the code is all there.