Bug 298198 - AAC file extension not recognised
Summary: AAC file extension not recognised
Status: RESOLVED MOVED
Alias: None
Product: taglib
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL: http://code.google.com/p/clementine-p...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-15 18:13 UTC by arnaud.bienner
Modified: 2018-11-09 09:17 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description arnaud.bienner 2012-04-15 18:13:26 UTC
User-Agent:       Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0
Build Identifier: 

Hi,

In Clementine Music Player, we rely on TagLib (among other things) to know if a file is valid or not.
As explained here:
http://code.google.com/p/clementine-player/issues/detail?id=1302
we aren't able to handle .aac files as TagLib told us they aren't valid.

Looking at http://en.wikipedia.org/wiki/Advanced_Audio_Coding, I thought that adding an extra check (ext == "AAC") in fileref.cpp (https://github.com/taglib/taglib/blob/master/taglib/fileref.cpp#L257 + add extension here: https://github.com/taglib/taglib/blob/master/taglib/fileref.cpp#L159) would be enough, but it doesn't work, using the file attached in our bug report.
But adding this check here: https://github.com/taglib/taglib/blob/master/taglib/fileref.cpp#L235
to consider it as a MPEG file solve the problem.
I'm sure .aac files are supposed to contain different kind of format (Wikipedia seems to suggest so: http://en.wikipedia.org/wiki/Advanced_Audio_Coding#Container_formats), but as it happens for many people, I suspect there are common cases when it may happen.
A check like the one you did for OGA file extension might be the solution.
Let me know what you think about this.
And thanks a lot for this wonderful library!

Arnaud

Reproducible: Always
Comment 1 arnaud.bienner 2012-04-15 18:15:18 UTC
> I'm sure .aac files are supposed to contain different kind of format
*I'm not sure (sorry for the typo)
Comment 2 Peter B. 2012-06-18 21:00:42 UTC
Is there any update on this bug's status?
Thanks! :)
Comment 3 Andrew Crouthamel 2018-11-09 01:02:21 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 4 arnaud.bienner 2018-11-09 09:17:59 UTC
This bug is specific to taglib, and just checking, it looks like taglib bugs are (now) reported on github.
And someone opened another bug report about this there: https://github.com/taglib/taglib/issues/508