Bug 298039 - Advanced Color Selector 'walks' selected color position at certain sizes
Summary: Advanced Color Selector 'walks' selected color position at certain sizes
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Color Selectors (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-13 10:27 UTC by Tom Hall
Modified: 2012-07-25 16:38 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Advanced Color Selector Size/Style that makes it walk (40.33 KB, image/jpeg)
2012-04-13 10:33 UTC, Tom Hall
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Hall 2012-04-13 10:27:04 UTC
User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0
Build Identifier: 

For certain sizes of the advanced colour selector, changing the hue causes the selected colour to 'walk' towards white.

Reproducible: Always

Steps to Reproduce:
1. Make the Advanced Color Selector the size and style shown in the attached screenshot
2. Select a colour of maximum chroma (right in the colourful corner)
3. Change the hue by clicking somewhere on the hue ring
4. Keep choosing new hues to exaggerate the problem
Actual Results:  
When a new hue is selected, the cursor (and selected colour) move slightly towards the white

Expected Results:  
Change hue without affecting the cursor's position in the triangle (don't alter any dimensions of colour except hue).

It isn't just the color selector's cursor that moves; after changing the hue many times, the selected colour *is* white.

Doesn't seem to happen with all sizes of the ACS. Suspect some sort of rounding error.

Occurs in git master.
Comment 1 Tom Hall 2012-04-13 10:33:28 UTC
Created attachment 70361 [details]
Advanced Color Selector Size/Style that makes it walk
Comment 2 Halla Rempt 2012-04-27 12:18:22 UTC
Yes, I can confirm.
Comment 3 Sven Langkamp 2012-07-22 16:17:23 UTC
Git commit cd88f24f32fb1b4c30b041d5e210bfd62facf9d9 by Sven Langkamp.
Committed on 22/07/2012 at 18:16.
Pushed by langkamp into branch 'master'.

fix slight movement in the color selector caused by rounding errors

M  +5    -2    krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_component.cpp

http://commits.kde.org/calligra/cd88f24f32fb1b4c30b041d5e210bfd62facf9d9
Comment 4 T Zachmann 2012-07-25 16:38:28 UTC
Git commit 508c1b50a408372928a94284da30f6dd0440ff86 by Thorsten Zachmann, on behalf of Sven Langkamp.
Committed on 22/07/2012 at 18:16.
Pushed by zachmann into branch 'calligra/2.5'.

fix slight movement in the color selector caused by rounding errors
(cherry picked from commit cd88f24f32fb1b4c30b041d5e210bfd62facf9d9)

M  +5    -2    krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_component.cpp

http://commits.kde.org/calligra/508c1b50a408372928a94284da30f6dd0440ff86