Bug 297956 - invitations are not signed with gpg although signing is enabled by default in kmail
Summary: invitations are not signed with gpg although signing is enabled by default in...
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: invitations (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-12 10:28 UTC by joke
Modified: 2023-07-04 05:39 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description joke 2012-04-12 10:28:13 UTC
User-Agent:       Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0
Build Identifier: 

Mail signing is enabled by default in Kmail. All outgoing emails are sign correctly.

Emails sent out by invitation are not signed. If a user signs emails by default invitations should be signed as well to ensure authenticity.

Reproducible: Always

Steps to Reproduce:
1. Send invitation
Actual Results:  
Email invitations were not signed.

Expected Results:  
Email invitations should have been signed.
Comment 1 Bug Janitor Service 2023-06-05 20:38:16 UTC
A possibly relevant merge request was started @ https://invent.kde.org/pim/akonadi-calendar/-/merge_requests/59
Comment 2 Daniel Vrátil 2023-07-04 05:39:36 UTC
Git commit 0841cbc08ca55dc7a05c20dfb32582a5e46cf644 by Daniel Vrátil.
Committed on 04/07/2023 at 05:39.
Pushed by dvratil into branch 'master'.

Sign/encrypt iTIP emails

This change implements support for signing and/or encrypting iTIP
emails. The code uses the MessageComposer::Composer to compose the
signed/encrypted message, so the same code as KMail to avoid duplicating
all the complex message-building logic. There's still a lot of code
duplication between this and the MessageComposer::ComposerViewBase
class, but that's not easily avoidable without larger refactoring of the
ComposerViewBase and further separating UI & logic.

It honors the organizer's crypto preferences (which is stored in the Identity
used for sending the iTIP email) as well as crypto preferences of all
attendees (which are loaded from KAddressbook).

The overall UX of this feature is kind of incomplete - there's no way
for the user to enable singing or encryption manually like in the KMail
composer and also there's no indication in the Incidence Editor UI whether
the iTIP email will be signed or encrypted. This can be addressed separately
in the incidenceeditor later, thought and I think it doesn't prevent
this feature from being merged. Also the message viewer in KMail is not
showing the pretty iTIP preview, just shows the cal.ics file as an
attachment.

M  +5    -0    CMakeLists.txt
M  +16   -2    autotests/CMakeLists.txt
A  +2    -0    autotests/gnupg_home/.#lk0x000055578376f8d0.bifrost.65618
A  +2    -0    autotests/gnupg_home/.#lk0x0000557aa7ed38a0.Brokkr.320445
A  +2    -0    autotests/gnupg_home/.#lk0x00005581b84e78a0.Brokkr.80512
A  +2    -0    autotests/gnupg_home/.#lk0x000055858a70d8d0.bifrost.55960
A  +2    -0    autotests/gnupg_home/.#lk0x0000561916f078d0.bifrost.88950
A  +2    -0    autotests/gnupg_home/.#lk0x00005630b5fd58d0.bifrost.88819
A  +0    -0    autotests/gnupg_home/.gpg-v21-migrated
A  +10   -0    autotests/gnupg_home/CMakeLists.txt
A  +3    -0    autotests/gnupg_home/dirmngr-cache.d/DIR.txt
A  +-    --    autotests/gnupg_home/dirmngr-cache.d/crl-4E31CEB57DDD4A7B9991AB05507B1ED4293FF952.db
A  +-    --    autotests/gnupg_home/dirmngr-cache.d/crl-7F2A402CBB016A9146D613568C89D3596A4111AA.db
A  +8    -0    autotests/gnupg_home/dirmngr.conf
A  +10   -0    autotests/gnupg_home/gpg-agent.conf.in
A  +244  -0    autotests/gnupg_home/gpg.conf
A  +10   -0    autotests/gnupg_home/gpgsm.conf.in
A  +35   -0    autotests/gnupg_home/openpgp-revocs.d/48BAF7236E952E4BDCF3748EA59CDFE1091524DC.rev
A  +35   -0    autotests/gnupg_home/openpgp-revocs.d/7E501DEA81F62DB17389393325058D1857FDD0E7.rev
A  +35   -0    autotests/gnupg_home/openpgp-revocs.d/E187A7C3FC78B3BDD2B3EF6495B9B82200EF61C6.rev
A  +9    -0    autotests/gnupg_home/pinentry-fake.sh
A  +-    --    autotests/gnupg_home/private-keys-v1.d/01A7EA42DB00E28D85BB27378D7A47829B63FDB6.key
A  +-    --    autotests/gnupg_home/private-keys-v1.d/1AA8BA52430E51AE249AF0DA97D59F869E4101A8.key
A  +-    --    autotests/gnupg_home/private-keys-v1.d/3BD9080DE9C88A88A67965B8E49F677004D6F6B7.key
A  +-    --    autotests/gnupg_home/private-keys-v1.d/53F70182AE3A9CFDDA3DA5B3A1742B875F43524B.key
A  +-    --    autotests/gnupg_home/private-keys-v1.d/61A7BB3E7F89151CFB8B18AC27668585CE77A7A7.key
A  +42   -0    autotests/gnupg_home/private-keys-v1.d/74D5844526608A22B14BD5320F3CF41122175D80.key
A  +-    --    autotests/gnupg_home/private-keys-v1.d/B8E914E1B03F0238FF0A999E69DE8C8D1FDFFFCD.key
A  +42   -0    autotests/gnupg_home/private-keys-v1.d/DC8D6F65743B70AB2EDFD4E2D067C66E62AB82AB.key
A  +-    --    autotests/gnupg_home/private-keys-v1.d/EC06D8C339EF73304D5B2CCF5363B437E0C915F2.key
A  +-    --    autotests/gnupg_home/pubring.kbx
A  +8    -0    autotests/gnupg_home/scdaemon.conf
A  +-    --    autotests/gnupg_home/secring.gpg
A  +11   -0    autotests/gnupg_home/sshcontrol
A  +-    --    autotests/gnupg_home/trustdb.gpg
A  +11   -0    autotests/gnupg_home/trustlist.txt
M  +256  -33   autotests/mailclienttest.cpp
A  +166  -0    cmake/modules/kdepim_add_gpg_crypto_test.cmake
A  +57   -0    cmake/modules/kdepim_generate_crypto_test_wrapper.cmake
M  +3    -0    src/CMakeLists.txt
M  +30   -0    src/itiphandler.h
M  +14   -0    src/itiphandlerhelper_p.cpp
M  +742  -174  src/mailclient_p.cpp
M  +85   -8    src/mailclient_p.h

https://invent.kde.org/pim/akonadi-calendar/-/commit/0841cbc08ca55dc7a05c20dfb32582a5e46cf644