Bug 297924 - MPRis Module has 2 variables called "active" and it's really confusing.
Summary: MPRis Module has 2 variables called "active" and it's really confusing.
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: kded-module (show other bugs)
Version: git-latest
Platform: unspecified Linux
: NOR task
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-11 19:29 UTC by David Edmundson
Modified: 2017-11-24 19:49 UTC (History)
4 users (show)

See Also:
Latest Commit: https://commits.kde.org/ktp-kded-module/20f845ce0c2e828700a79efd455f9700deafb1d7
Version Fixed In: 18.04
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description David Edmundson 2012-04-11 19:29:44 UTC 
TelepathyMprisModule has m_presenceActivated
TelepathyKDEDModulePlugin has m_active and m_enabled

None of these are documented and it's messy.
Comment 1 moses 2012-05-15 17:37:45 UTC 
On first look, I think they all serve their intended purpose. Is this bug raised for cleaning it up or documenting the code ?
Comment 2 Martin Klapetek 2012-05-15 18:39:45 UTC 
Probably both ;) The m_presenceActivated is used for when the contact list sets this presence - it signals that over dbus and kded-module catches it and activates the mpris plugin. So - m_presenceActivated is true if contact list has such presence and m_active is true if the plugin is currently in control of the presence (ie. the current presence was set by this plugin).

Totally agreed on the documentation.
Comment 3 Jamie Smith 2017-11-22 01:04:17 UTC 
Git commit 20f845ce0c2e828700a79efd455f9700deafb1d7 by James D. Smith.
Committed on 22/11/2017 at 01:03.
Pushed by smithjd into branch 'master'.

Independent account presences.
Activities support.
Make unit testing compile.
Implement status message parser with Now Playing.
Status message parser unit testing.
REVIEW: 130192
Related: bug 284517, bug 293443, bug 294940, bug 334542

M  +5    -3    CMakeLists.txt
A  +208  -0    account-status-helper.cpp     [License: LGPL (v2.1+)]
A  +115  -0    account-status-helper.h     [License: LGPL (v2.1+)]
M  +31   -41   autoaway.cpp
M  +4    -8    autoaway.h
D  +0    -62   autoconnect.cpp
D  +0    -99   autoconnect.h
M  +0    -2    config/CMakeLists.txt
D  +0    -80   config/nowplaying-lineedit.cpp
D  +0    -43   config/nowplaying-lineedit.h
D  +0    -107  config/nowplaying-listwidget.cpp
D  +0    -50   config/nowplaying-listwidget.h
M  +34   -122  config/telepathy-kded-config.cpp
M  +0    -4    config/telepathy-kded-config.h
M  +10   -73   config/telepathy-kded-config.ui
M  +18   -27   screensaveraway.cpp
M  +2    -5    screensaveraway.h
M  +182  -149  status-handler.cpp
M  +24   -32   status-handler.h
A  +303  -0    status-message-parser.cpp     [License: LGPL (v2.1+)]
A  +97   -0    status-message-parser.h     [License: LGPL (v2.1+)]
M  +17   -13   telepathy-kded-module-plugin.cpp
M  +34   -22   telepathy-kded-module-plugin.h
M  +4    -1    telepathy-module.cpp
M  +0    -1    telepathy-module.h
M  +192  -236  telepathy-mpris.cpp
M  +33   -28   telepathy-mpris.h
M  +33   -11   tests/CMakeLists.txt
M  +3    -3    tests/status-handling-main.cpp
A  +132  -0    tests/status-message-parser.cpp     [License: LGPL (v2.1+)]

https://commits.kde.org/ktp-kded-module/20f845ce0c2e828700a79efd455f9700deafb1d7