Bug 297316 - translations and docs off by default
Summary: translations and docs off by default
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Bundle-Tarball (show other bugs)
Version: 2.6.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 14:39 UTC by nucleo
Modified: 2022-02-04 06:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.5.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description nucleo 2012-04-02 14:39:49 UTC
Translations and docs are disabled by default in digikam-2.6.0-beta3.
There are new options added in CMakeLists.txt since beta2 with default OFF:

OPTION(DIGIKAMSC_COMPILE_PO              "Build translations files (default=OFF)"                                                 OFF)
OPTION(DIGIKAMSC_COMPILE_DOC             "Build handbook files (default=OFF)"                                                     OFF)
Comment 1 caulier.gilles 2012-04-02 14:42:35 UTC
DIGIKAMSC_COMPILE_PO is for packaging only. So it's disabled
turn on DIGIKAMSC_COMPILE_DOC is you really want it...

This is the purpose of option...
Gilles Caulier
Comment 2 Kevin Kofler 2012-04-02 14:45:38 UTC
1. Users compiling from source want translations and documentation too.
2. The defaults should be sensible for packaging where possible. (I understand why the default prefix is not /usr, but that's commonplace, having to manually enable translations and documentation is not.)
Comment 3 caulier.gilles 2012-04-02 14:49:56 UTC
PO file can be only compiled only if you get all .po files from KDE git repository, through a dedicated script. Turning on this option will not do it...

Gilles Caulier
Comment 4 Kevin Kofler 2012-04-02 14:51:19 UTC
Aren't your tarballs built with that "dedicated script"? They're supposed to.
Comment 5 caulier.gilles 2012-04-20 11:05:36 UTC
Git commit 38294d3b20b787db0f4167b67b8cec6e920b4907 by Gilles Caulier.
Committed on 20/04/2012 at 13:02.
Pushed by cgilles into branch 'master'.

re-enable DOC and PO dir compilation by default. Add check to see if PO dir exist in case of packager do not have checkout previouly translation files.

M  +11   -6    CMakeLists.txt
M  +2    -2    README

http://commits.kde.org/scratch/mwiesweg/digikam-sc/38294d3b20b787db0f4167b67b8cec6e920b4907
Comment 6 S. Burmeister 2012-04-26 20:43:06 UTC
The check broke translation compilation, i.e. it does not find the po folder although it exists:

kde-branch@linux-ly0d:~/kde/src/digikam-software-compilation> ls -la
insgesamt 236
drwxr-xr-x  9 kde-branch users  4096 26. Apr 22:39 .
drwxr-xr-x  4 kde-branch users  4096 11. Mär 15:53 ..
-rwxr-xr-x  1 kde-branch users  1449 24. Mär 00:56 bootstrap.macports
-rwxr-xr-x  1 kde-branch users   978 24. Mär 00:56 bootstrap.mageia
-rwxr-xr-x  1 kde-branch users   574  4. Feb 21:23 bootstrap.mandriva
-rwxr-xr-x  1 kde-branch users  1348 24. Mär 00:56 bootstrap.mingw.bat
-rwxr-xr-x  1 kde-branch users  1293 24. Mär 00:56 bootstrap.msvc.bat
-rwxr-xr-x  1 kde-branch users   344 24. Mär 00:56 bootstrap.ubuntu
drwxr-xr-x  3 kde-branch users  4096  4. Feb 21:23 cmake
-rw-r--r--  1 kde-branch users  4746 26. Apr 22:39 CMakeLists.txt
-rw-r--r--  1 kde-branch users 18011  3. Mär 10:41 COPYING
-rw-r--r--  1 kde-branch users  1327  3. Mär 10:41 COPYING-CMAKE-SCRIPTS
-rw-r--r--  1 kde-branch users 20403  3. Mär 10:41 COPYING.DOC
-rw-r--r--  1 kde-branch users 26527  3. Mär 10:41 COPYING.LIB
drwxr-xr-x 15 kde-branch users  4096 26. Apr 21:45 core
drwxr-xr-x  4 kde-branch users  4096 28. Mär 11:26 doc
-rwxr-xr-x  1 kde-branch users   295  4. Feb 21:23 download-repos
drwxr-xr-x 11 kde-branch users  4096 28. Mär 11:26 extra
drwxr-xr-x  8 kde-branch users  4096 26. Apr 22:39 .git
-rw-r--r--  1 kde-branch users   165  4. Feb 21:23 .gitignore
-rwxr-xr-x  1 kde-branch users 74105  4. Feb 21:23 gits
-rw-r--r--  1 kde-branch users   379  4. Feb 21:23 .gitslave
-rw-r--r--  1 kde-branch users    77  4. Feb 21:23 NEWS
drwxr-xr-x 92 kde-branch users  4096 28. Mär 13:46 po
drwxr-xr-x  4 kde-branch users  4096 19. Mär 00:04 project
-rw-r--r--  1 kde-branch users  3908 21. Apr 09:55 README