Bug 297217 - Default Places panel width too narrow with >96 DPI
Summary: Default Places panel width too narrow with >96 DPI
Status: CONFIRMED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: Open/save dialogs (show other bugs)
Version: 5.47.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2012-04-01 02:40 UTC by Felix Miata
Modified: 2020-02-12 22:32 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
120 DPI 4.10.0-1 picker window snapshot in virgin user session on openSUSE 12.3 (171.60 KB, image/png)
2013-03-12 08:53 UTC, Felix Miata
Details
120 DPI 4.10.0-1 picker window snapshot in virgin user session on openSUSE 12.3 (74.14 KB, image/png)
2013-03-12 09:03 UTC, Felix Miata
Details
screenshot: 1440x900 96 DPI 4.10.1 save as window on openSUSE 12.2 (192.11 KB, image/png)
2013-04-02 01:02 UTC, Felix Miata
Details
screenshot: 1600x1200 120 DPI 4.10.1 save as window on Mageia 3 (284.84 KB, image/png)
2013-04-02 01:02 UTC, Felix Miata
Details
1920x1440 144 DPI 4.10.1 save as window screenshot on Fedora 18 (311.67 KB, image/png)
2013-04-02 01:02 UTC, Felix Miata
Details
Fedora 19 KDM 4.10.5 save as window screenshot (133.78 KB, image/png)
2013-08-03 20:54 UTC, Felix Miata
Details
save window screenshot on 4.10.5 @1024x768x86DPI (82.41 KB, image/png)
2013-09-08 02:30 UTC, Felix Miata
Details
144 DPI screenshot from Spectacle 17.04.3 on openSUSE Tumbleweed (87.34 KB, image/png)
2017-08-20 16:01 UTC, Felix Miata
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Miata 2012-04-01 02:40:06 UTC
This sprung from bug 283366 where screenshot https://bugs.kde.org/attachment.cgi?id=70044 shows the inane narrowness of the (KSnapshot) default left pane width in the default width picker window in 4.8.1 (from build service repo) on openSUSE 12.1.

Issues:
1-A minimum width is needed wider than current default
2-pane width needs to persist into next open when it's been adjusted to a useful width
3-left pane icons do little but waste space

Bug 186253 is similar, but I see as distinguishable.
Comment 1 Felix Miata 2013-03-12 08:53:04 UTC
Created attachment 77976 [details]
120 DPI 4.10.0-1 picker window snapshot in virgin user session on openSUSE 12.3
Comment 2 Felix Miata 2013-03-12 09:03:52 UTC
Created attachment 77977 [details]
120 DPI 4.10.0-1 picker window snapshot in virgin user session on openSUSE 12.3
Comment 3 Gérard Talbot (no longer involved) 2013-04-01 22:23:09 UTC
Felix,

I have read your comments and I have tried to reproduce the problem (unusable narrow Places left pane) and I could not.

Interestingly, your screenshot of FilePicker does not show the Favorites iconified with a yellow star while I see Favorites iconified with a yellow star on the far right-hand side of the FilePicker: I can upload a screenshot if requested.
I believe - and I could be wrong here - that FilePicker may be using some user pref Dolphin settings.

I am using
Kubuntu 12.10
KDE platform development version 4.10.1
DPI settings: 96
screen resolution: 1024x768
Qt version: 4.8.3
Linux 3.5.0-26-generic i686 (32bits)
and I have/am using Dolphin version 2.2

Gérard
Comment 4 Felix Miata 2013-04-02 01:02:06 UTC
Created attachment 78567 [details]
screenshot: 1440x900 96 DPI 4.10.1 save as window on openSUSE 12.2

taken with KDE virgin user's first login - only showing window resized is Konsole's
Comment 5 Felix Miata 2013-04-02 01:02:15 UTC
Created attachment 78568 [details]
screenshot: 1600x1200 120 DPI 4.10.1 save as window on Mageia 3
Comment 6 Felix Miata 2013-04-02 01:02:22 UTC
Created attachment 78569 [details]
1920x1440 144 DPI 4.10.1 save as window screenshot on Fedora 18

taken with KDE virgin user's first login - only showing window resized is Konsole's

(In reply to comment #3)
> I have read your comments and I have tried to reproduce the problem
> (unusable narrow Places left pane) and I could not.

I cannot not reproduce it using Fedora 18, Mageia 3 or openSUSE 12.x. The problem on Mageia is less severe than the openSUSE 12.3 attachment 77977 [details] that is also @ 120 DPI, or the other two. I have no idea why - unless the initial left pane width is somehow tied to the longest folder name in $HOME, which is longest in Mageia.
 
> Interestingly, your screenshot of FilePicker does not show the Favorites
> iconified with a yellow star while I see Favorites iconified with a yellow
> star on the far right-hand side of the FilePicker: I can upload a screenshot
> if requested.
> I believe - and I could be wrong here - that FilePicker may be using some
> user pref Dolphin settings.

I'm an OFM user who has never used Dolphin, so any Dolphin settings that may exist must be KDE defaults.
Comment 7 Christoph Feck 2013-04-16 17:54:40 UTC
The problem here is that the places panel determines its initial size based on the static entries (system places and custom user places) only. When later disks are scanned, it adds the dynamic entries (removeable devices, mounted partitions, etc), without recomputing its initial size.

Possible fixes:
- do not add the dynamic entries delayed => would significantly increase the time the dialog opens
- recompute the initial size once delayed entries are added => ugly shifting behavior of the dialog on every open
- use an arbitrary (larger) initial size, e.g. based on font width, without looking at the entries at all

I do not like either of the solutions. When the user is able to resize the splitter, the dialog should simply remember the width for future invokations.
Comment 8 Felix Miata 2013-04-16 18:28:27 UTC
(In reply to comment #7)
> The problem here is that the places panel determines its initial size based
> on the static entries (system places and custom user places) only. When
> later disks are scanned, it adds the dynamic entries (removeable devices,
> mounted partitions, etc), without recomputing its initial size.
> 
> Possible fixes:
> - do not add the dynamic entries delayed => would significantly increase the
> time the dialog opens
> - recompute the initial size once delayed entries are added => ugly shifting
> behavior of the dialog on every open
> - use an arbitrary (larger) initial size, e.g. based on font width, without
> looking at the entries at all
> 
> I do not like either of the solutions. When the user is able to resize the
> splitter, the dialog should simply remember the width for future invokations.

Memory is my favorite, but IMO it should have a minimum width on every open based on font size allowing at least 15ex (ex as x-height being on average equal to average character width, making 15ex typically equivalent to 7.5em; IIRC, 15 being the native volume label limit, but also enough for two or so average words) to show in addition to any ellipsis for excess beyond 15.
Comment 9 Felix Miata 2013-08-03 20:54:30 UTC
Created attachment 81549 [details]
Fedora 19 KDM 4.10.5 save as window screenshot

Still crazy 16 months later. Here KScreen 1.0.1 is overruling xorg.conf settings, and disallowing any corrections via systemsettings.
Comment 10 Felix Miata 2013-09-08 02:30:25 UTC
Created attachment 82211 [details]
save window screenshot on 4.10.5 @1024x768x86DPI
Comment 11 Felix Miata 2015-03-25 04:55:21 UTC
As of KF5.8 the "always" part seems may be gone. Nevertheless, for a new login/user/profile using a >96DPI screen, the initial width is too narrow. The first instance width needs to be character size based, not a pixel width.
Comment 12 Felix Miata 2017-08-20 16:01:43 UTC
Created attachment 107408 [details]
144 DPI screenshot from Spectacle 17.04.3 on openSUSE Tumbleweed

This a11y/u7y situational impairment continues as of KF5.36.
Comment 13 Christoph Feck 2017-09-17 16:51:51 UTC
Felix, the bug has already been investigated, see comment #7, so there is no reason to continue nagging.
Comment 14 Felix Miata 2017-09-20 06:16:47 UTC
(In reply to Christoph Feck from comment #7)
"...-use an arbitrary (larger) initial size, e.g. based on font width, without
looking at the entries at all

I do not like either of the solutions."

1: "Either:... "one or the other of two"
http://www.dictionary.com/browse/either?s=t

You listed three items. I too do not like either of the first two, while the third almost perfectly describes the ideal....

2: The third item makes much more sense than the already arbitrary initial window size. Basing the size on font size is how it should already be done. The arbitrary current sizing could work by simply converting its design px sizes to the em values of those sizes using the default font size, so that those needing larger fonts automatically get a larger window *and* pane sizes that maintain the designer's proportions.

Px sizing is an abomination that works only for those with youthful eyes and those who don't mind straining to see what they need to see, and then only if the designer wisely employs empathy for those whose vision is less than perfect.

"When the user is able to resize the
splitter, the dialog should simply remember the width for future invokations."

This should already be the case too, but it's less critical that intelligent initial size. A too small initial size means both the slider needs to be moved and the window needs to be bigger.
Comment 15 Nate Graham 2020-02-12 22:32:08 UTC
*** Bug 417512 has been marked as a duplicate of this bug. ***