Bug 296580 - Allow to choose photo date-time stamp from digiKam main window
Summary: Allow to choose photo date-time stamp from digiKam main window
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-TimeAdjust (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 20:29 UTC by Dotan Cohen
Modified: 2018-09-22 08:33 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.4.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dotan Cohen 2012-03-22 20:29:49 UTC
Digikam has a terrific "Determine time difference with clock photo" feature. However, this feature requires one to select a photo from the KDE File Chooser dialogue. Please update this feature to use the Digikam main window for selection. Thanks.

The "Determine time difference with clock photo" feature can be accessed from the "Adjust Date & Time" dialogue.
Comment 1 Smit Mehta 2012-04-19 14:27:58 UTC
Hi Gilles

Do we have a file chooser from KIPI Host? Is it KIPIUploadWidget?

Smit
Comment 2 caulier.gilles 2012-04-19 14:43:03 UTC
No. KIPIUploadWidget is to get album selection from KIPI host to upload from kipi-plugins to kipi host collection.

KPImageDialog is the right widget to use for this action...

Gilles
Comment 3 Smit Mehta 2012-04-19 14:52:37 UTC
Hi Gilles

The current implementation uses KPImageDialog only. It is like a normal file-chooser only. But Dotan wants to select images within digiKam only, is there any way to do that?

Smit
Comment 4 caulier.gilles 2012-04-19 14:56:22 UTC
It's not implemented to limit access to digiKam collections. At least we can pass path from main root digiKam album to image dialog.

Gilles
Comment 5 caulier.gilles 2012-04-19 14:57:53 UTC
Another way is to open D&D feature with KPImageList. As TimeAjustDialog is non modal, it's very easy to do. KPImageList as D&D feature implemented...

Gilles Caulier
Comment 6 Smit Mehta 2012-10-07 12:20:07 UTC
Hi Dotan, Gilles

In my personal opinion, the current implementation is good enough. We should not restrict the user to select the clock photo only form digiKam's collections. Although, the file chooser by default opens with current album only, so it shouldnt be much of a problem if user wants the image from the same folder as that very same folder opens by default in the file chooser.

Another way out is to have a drag and drop feature, where user can drag the photo from anywhere (digikam's collections or from dolphin or from anywhere), and then its selected.

What are your thoughts? What should I do?

Smit
Comment 7 caulier.gilles 2012-10-07 12:45:08 UTC
I like D&D feature. Not too complicated to implemented, and already done in some other plugins.

Gilles
Comment 8 Dotan Cohen 2012-10-14 08:07:29 UTC
> We should not restrict the user to select the clock photo only form digiKam's collections.
>

The goal is not to limit the user to selecting only photos from within Digikam, but rather to make it easier to user photos that are already in Digikam.
Comment 9 Smit Mehta 2012-10-14 15:24:45 UTC
@Gilles
Alright. I will implement the D&D feature using KPImagesList. So, I will be creating a new KDialog, where i will use this widget. But there is one problem? How should I ensure that user enters only one image? Should I disable the "Okay" on the new created KDialog if the images are not equal to 1? Or can i write a signal in KPImagesList which will get emitted as soon as the no. of images become one? Which solution you think is better?

Smit
Comment 10 Dotan Cohen 2012-10-14 15:32:37 UTC
Will the new D&D interface allow easy selection from Digikam? In my opinion, it is to assume that the wanted image is already in Digikam, though I agree that the user should not be prevented from using a non-Digikam image.

Just think of the workflow: a single event in which multiple cameras are shooting. All the images are then imported into Digikam. The user should be able to click an image with a clock, and adjust that image and all images taken with the same camera in the same event. Setting the event boundaries may be problematic: one does not want to adjust all images of the collection taken with that camera, and any single event might span more than one calendar day (weddings that go on into the night, multiple-day cruises, month-long camping trips, etc.).

Having the user select which images came from which camera will be very error-prone. Probably the exif data could be used for this, at least as a first approximation.
Comment 11 Smit Mehta 2012-10-15 16:11:06 UTC
@Gilles

what is your final opinion / decision? What shall I do?

Smit
Comment 12 caulier.gilles 2012-10-22 07:43:26 UTC
Smit,

2 solutions, both are fine to be implemented :

1/ add KPImageDialog a new option to be able to look outside kipi host collection. This option must be disabled by default

2/ add D&D feature in your tool to be able to drag an item from everywhere and drop it over "Determine Difference From Clock Photo" button from settings view.

My preferred way is 2/, as i use D&D everywhere when i can. 1/ Can be implemented too, in parallel.

Gilles
Comment 13 Smit Mehta 2012-10-23 17:54:05 UTC
Gilles

I assume in 1), you meant i add an option to be able to look INSIDE a kipi host collection. It is by default opens a file chooser, i.e. for selecting outside files. I will see if there is an elegant way of putting a ImageCollectionSelector here.

According to me, 1. is more preffered. D&D works elegantly only if you have multiple screens. Otherwise, if you are on a single screen system, when you select something to drag, the dialog will get minimized. So you have to drag it to the bottom, to the task bar and then drag it back to the dialog. So I will work on first idea. Fine?

Smit
Comment 14 Kusi 2017-01-02 00:23:07 UTC
When you're in the batch queue manager, please allow to drag & drop from the "Queues" window to the "determine difference from clock photo" button.
Comment 15 Kusi 2017-01-03 01:14:01 UTC
Patch under review

https://git.reviewboard.kde.org/r/129755/
Comment 16 Kusi 2017-01-03 13:38:07 UTC
Issue fixed with commit
https://cgit.kde.org/digikam.git/commit/?id=72c97cef18b260d2143261b72373e7ba53ba3dfb

You can drag&drop a photo onto the "determine difference" button from anywhere
Comment 17 Kusi 2017-01-03 13:38:56 UTC
Issue fixed with commit
https://cgit.kde.org/digikam.git/commit/?id=72c97cef18b260d2143261b72373e7ba53ba3dfb

You can drag&drop a photo onto the "determine difference" button from anywhere