Bug 296423 - Amarok fails to compile with taglib from master
Summary: Amarok fails to compile with taglib from master
Status: RESOLVED FIXED
Alias: None
Product: taglib
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 10:58 UTC by Christoph Feck
Modified: 2012-05-07 22:56 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Include tmap.h to fix compile of Amarok (383 bytes, patch)
2012-03-29 21:16 UTC, Chris Burel 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2012-03-20 10:58:36 UTC 
Since the recent merge in taglib, the Amarok application fails to compile. Errors:

> In file included from /local/git/extragear/multimedia/amarok/shared/MetaReplayGain.cpp:29:0:
> /local/kde4/include/taglib/textidentificationframe.h:39:13: error: 'Map' does not name a type
> /local/kde4/include/taglib/textidentificationframe.h:195:20: error: 'KeyConversionMap' does not name a type
> In file included from /local/git/extragear/multimedia/amarok/shared/MetaReplayGain.cpp:31:0:
> /local/kde4/include/taglib/fileref.h:92:25: warning: 'class TagLib::FileRef::FileTypeResolver' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
> make[2]: *** [src/CMakeFiles/amaroklib.dir/__/shared/MetaReplayGain.o] Error 1
> make[2]: Target `src/CMakeFiles/amaroklib.dir/build' not remade because of errors.
> make[1]: *** [src/CMakeFiles/amaroklib.dir/all] Error 2
> In file included from /local/git/extragear/multimedia/amarok/shared/MetaReplayGain.cpp:29:0:
> /local/kde4/include/taglib/textidentificationframe.h:39:13: error: 'Map' does not name a type
> /local/kde4/include/taglib/textidentificationframe.h:195:20: error: 'KeyConversionMap' does not name a type
> In file included from /local/git/extragear/multimedia/amarok/shared/MetaReplayGain.cpp:31:0:
> /local/kde4/include/taglib/fileref.h:92:25: warning: 'class TagLib::FileRef::FileTypeResolver' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
> make[2]: *** [utilities/collectionscanner/CMakeFiles/amarokcollectionscanner.dir/__/__/shared/MetaReplayGain.o] Error 1
> make[2]: Target `utilities/collectionscanner/CMakeFiles/amarokcollectionscanner.dir/build' not remade because of errors.
> make[1]: *** [utilities/collectionscanner/CMakeFiles/amarokcollectionscanner.dir/all] Error 2
> make[1]: Target `all' not remade because of errors.
> make: *** [all] Error 2
> make: Target `default_target' not remade because of errors.
> -- Failed: extragear/multimedia/amarok
Comment 1 Chris Burel 2012-03-29 21:16:34 UTC 
Created attachment 70001 [details]
Include tmap.h to fix compile of Amarok

This is because a new typedef was introduced, using a "Map".  But the "Map" type is not explicitly included by Amarok code.  If this header needs the Map type defined, it should include the appropriate file.
Comment 2 Christoph Feck 2012-05-07 22:56:07 UTC 
Fixed with commit 2297a6d531e3e1d347c394095ae14403a11bb6dd