Bug 296229 - Linux user input device ioctls missing wrappers
Summary: Linux user input device ioctls missing wrappers
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: 3.7.0
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-17 19:14 UTC by Chase Douglas
Modified: 2012-07-13 19:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add ioctl wrappers for linux user input devices (1.89 KB, application/octet-stream)
2012-03-17 19:14 UTC, Chase Douglas 		Details
Add uinput ioctl wrappers (2.27 KB, patch)
2012-07-05 15:27 UTC, Chase Douglas 		Details
Show Obsolete (1) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Chase Douglas 2012-03-17 19:14:20 UTC 
Created attachment 69693 [details]
Add ioctl wrappers for linux user input devices

The user input device ioctls defined in linux/uinput.h need wrappers because they either don't provide a third argument or they provide an int value instead of a pointer to a memory location.
Comment 1 Chase Douglas 2012-03-17 19:15:17 UTC 
Although I'm reporting the bug against Ubuntu's valgrind package because it's what I've tested with, the attached patch is against a trunk svn checkout.
Comment 2 Julian Seward 2012-07-04 20:10:09 UTC 
(In reply to comment #0)
> Created attachment 69693 [details]
> Add ioctl wrappers for linux user input devices

This looks like a patch for XOrg, not for Valgrind.  Did you get the
right one?
Comment 3 Chase Douglas 2012-07-05 15:26:22 UTC 
Comment on attachment 69693 [details]
Add ioctl wrappers for linux user input devices

Yes, the patch is bogus. I'll attach the patch I applied to the Ubuntu package.
Comment 4 Chase Douglas 2012-07-05 15:27:15 UTC 
Created attachment 72333 [details]
Add uinput ioctl wrappers
Comment 5 Julian Seward 2012-07-13 13:16:16 UTC 
Committed, r12737.  Thanks for the patch.
I had to apply one of the hunks by hand -- I think it conflicted with
some other recent ioctl commits.  So it would be good if you could 
check over the commit to see it's OK.  Thanks.
Comment 6 Chase Douglas 2012-07-13 19:13:14 UTC 
I haven't built and tested it, but the committed change looks correct.

Thanks!