Bug 296116 - Q_ASSERT(display); crashes
Summary: Q_ASSERT(display); crashes
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR crash
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
: 296154 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-03-16 00:03 UTC by Christoph Feck
Modified: 2012-03-16 14:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2012-03-16 00:03:39 UTC 
Since commit 02ac6dbf4d102384c08ad6d364aacd2a204bc105 exiting Konsole I hit the assert in ViewManager.cpp::731

I tried changing dynamic_cast to the more correct qobject_cast, but it still asserts, so it looks like viewCloseRequest() is called with a widget that isn't a TerminalDisplay at all.
Comment 1 Jekyll Wu 2012-03-16 01:58:07 UTC 
Git commit edd9d2cfdfd23ffea695452cfc404d8f9a4ce865 by Jekyll Wu.
Committed on 16/03/2012 at 02:50.
Pushed by jekyllwu into branch 'master'.

Revert "Use the appropriate casting"

The received QWidget has already been destroyed, so using dynamic_cast
or qobject_cast does not work.

Another stupid mistake by me !

This reverts commit 02ac6dbf4d102384c08ad6d364aacd2a204bc105.

M  +3    -1    src/ViewManager.cpp

http://commits.kde.org/konsole/edd9d2cfdfd23ffea695452cfc404d8f9a4ce865
Comment 2 Jekyll Wu 2012-03-16 14:09:49 UTC 
*** Bug 296154 has been marked as a duplicate of this bug. ***